diff --git a/llvm/include/llvm/Bitstream/BitstreamReader.h b/llvm/include/llvm/Bitstream/BitstreamReader.h index b49a969a2d8bdb4c81ae537c614651b4c77f57b1..c476f60420faebef3047556d39ec487a67cd2a91 100644 --- a/llvm/include/llvm/Bitstream/BitstreamReader.h +++ b/llvm/include/llvm/Bitstream/BitstreamReader.h @@ -39,7 +39,7 @@ public: /// This contains information emitted to BLOCKINFO_BLOCK blocks. These /// describe abbreviations that all blocks of the specified ID inherit. struct BlockInfo { - unsigned BlockID; + unsigned BlockID = 0; std::vector> Abbrevs; std::string Name; std::vector> RecordNames; diff --git a/llvm/include/llvm/Remarks/Remark.h b/llvm/include/llvm/Remarks/Remark.h index 73b2680e98da48d24f5aea102212f5d73644403b..6211db4a8e96ed54b4efc3b456894d7a7e4dc22b 100644 --- a/llvm/include/llvm/Remarks/Remark.h +++ b/llvm/include/llvm/Remarks/Remark.h @@ -30,8 +30,8 @@ constexpr uint64_t CurrentRemarkVersion = 0; struct RemarkLocation { /// Absolute path of the source file corresponding to this remark. StringRef SourceFilePath; - unsigned SourceLine; - unsigned SourceColumn; + unsigned SourceLine = 0; + unsigned SourceColumn = 0; }; // Create wrappers for C Binding types (see CBindingWrapping.h). diff --git a/llvm/lib/Remarks/BitstreamRemarkParser.cpp b/llvm/lib/Remarks/BitstreamRemarkParser.cpp index 1cfde11922295fb0fa9a3c55f92a5e97a45bdf82..dfad5902545acfa66bc281703180e6240d8c1f81 100644 --- a/llvm/lib/Remarks/BitstreamRemarkParser.cpp +++ b/llvm/lib/Remarks/BitstreamRemarkParser.cpp @@ -174,7 +174,7 @@ static Error parseBlock(T &ParserHelper, unsigned BlockID, // Stop when there is nothing to read anymore or when we encounter an // END_BLOCK. while (!Stream.AtEndOfStream()) { - Expected Next = Stream.advance(); + Next = Stream.advance(); if (!Next) return Next.takeError(); switch (Next->Kind) { @@ -366,15 +366,15 @@ Error BitstreamRemarkParser::parseMeta() { } Error BitstreamRemarkParser::processCommonMeta( - BitstreamMetaParserHelper &MetaHelper) { - if (Optional Version = MetaHelper.ContainerVersion) + BitstreamMetaParserHelper &Helper) { + if (Optional Version = Helper.ContainerVersion) ContainerVersion = *Version; else return createStringError( std::make_error_code(std::errc::illegal_byte_sequence), "Error while parsing BLOCK_META: missing container version."); - if (Optional Type = MetaHelper.ContainerType) { + if (Optional Type = Helper.ContainerType) { // Always >= BitstreamRemarkContainerType::First since it's unsigned. if (*Type > static_cast(BitstreamRemarkContainerType::Last)) return createStringError( diff --git a/llvm/lib/Remarks/BitstreamRemarkParser.h b/llvm/lib/Remarks/BitstreamRemarkParser.h index 7c9cc2f1e7db0dd91fe646bced0fa6819760187c..749219fc5155027888a3d92d8e54764a6179b479 100644 --- a/llvm/lib/Remarks/BitstreamRemarkParser.h +++ b/llvm/lib/Remarks/BitstreamRemarkParser.h @@ -34,15 +34,16 @@ struct BitstreamRemarkParser : public RemarkParser { std::unique_ptr TmpRemarkBuffer; /// The common metadata used to decide how to parse the buffer. /// This is filled when parsing the metadata block. - uint64_t ContainerVersion; - uint64_t RemarkVersion; - BitstreamRemarkContainerType ContainerType; + uint64_t ContainerVersion = 0; + uint64_t RemarkVersion = 0; + BitstreamRemarkContainerType ContainerType = + BitstreamRemarkContainerType::Standalone; /// Wether the parser is ready to parse remarks. bool ReadyToParseRemarks = false; /// Create a parser that expects to find a string table embedded in the /// stream. - BitstreamRemarkParser(StringRef Buf) + explicit BitstreamRemarkParser(StringRef Buf) : RemarkParser(Format::Bitstream), ParserHelper(Buf) {} /// Create a parser that uses a pre-parsed string table.