From be33e8d58dc3689224312d48ebcc152dd9fe7df1 Mon Sep 17 00:00:00 2001 From: Bill Wendling Date: Tue, 16 Aug 2011 04:52:55 +0000 Subject: [PATCH] A few places where we want to skip the landingpad instruction for insertion. llvm-svn: 137712 --- llvm/lib/Analysis/ScalarEvolutionExpander.cpp | 5 ++++- .../Transforms/InstCombine/InstCombineLoadStoreAlloca.cpp | 1 + llvm/lib/Transforms/Instrumentation/GCOVProfiling.cpp | 4 +++- 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/llvm/lib/Analysis/ScalarEvolutionExpander.cpp b/llvm/lib/Analysis/ScalarEvolutionExpander.cpp index 35a8f55585f2..e1ad2f91ca1a 100644 --- a/llvm/lib/Analysis/ScalarEvolutionExpander.cpp +++ b/llvm/lib/Analysis/ScalarEvolutionExpander.cpp @@ -1323,8 +1323,11 @@ Value *SCEVExpander::expand(const SCEV *S) { // If the SCEV is computable at this level, insert it into the header // after the PHIs (and after any other instructions that we've inserted // there) so that it is guaranteed to dominate any user inside the loop. - if (L && SE.hasComputableLoopEvolution(S, L) && !PostIncLoops.count(L)) + if (L && SE.hasComputableLoopEvolution(S, L) && !PostIncLoops.count(L)) { InsertPt = L->getHeader()->getFirstNonPHI(); + if (isa(InsertPt)) + InsertPt = llvm::next(BasicBlock::iterator(InsertPt)); + } while (isInsertedInstruction(InsertPt) || isa(InsertPt)) InsertPt = llvm::next(BasicBlock::iterator(InsertPt)); break; diff --git a/llvm/lib/Transforms/InstCombine/InstCombineLoadStoreAlloca.cpp b/llvm/lib/Transforms/InstCombine/InstCombineLoadStoreAlloca.cpp index e4012ef759ba..b987340e13f2 100644 --- a/llvm/lib/Transforms/InstCombine/InstCombineLoadStoreAlloca.cpp +++ b/llvm/lib/Transforms/InstCombine/InstCombineLoadStoreAlloca.cpp @@ -601,6 +601,7 @@ bool InstCombiner::SimplifyStoreAtEndOfBlock(StoreInst &SI) { // Advance to a place where it is safe to insert the new store and // insert it. BBI = DestBB->getFirstNonPHI(); + if (isa(BBI)) ++BBI; StoreInst *NewSI = new StoreInst(MergedVal, SI.getOperand(1), SI.isVolatile(), SI.getAlignment(), diff --git a/llvm/lib/Transforms/Instrumentation/GCOVProfiling.cpp b/llvm/lib/Transforms/Instrumentation/GCOVProfiling.cpp index 3a7f21c4ce45..4f22bbc9c7f6 100644 --- a/llvm/lib/Transforms/Instrumentation/GCOVProfiling.cpp +++ b/llvm/lib/Transforms/Instrumentation/GCOVProfiling.cpp @@ -505,7 +505,9 @@ bool GCOVProfiler::emitProfileArcs(DebugInfoFinder &DIF) { } for (int i = 0, e = ComplexEdgeSuccs.size(); i != e; ++i) { // call runtime to perform increment - IRBuilder<> Builder(ComplexEdgeSuccs[i+1]->getFirstNonPHI()); + BasicBlock::iterator InsertPt = ComplexEdgeSuccs[i+1]->getFirstNonPHI(); + if (isa(InsertPt)) ++InsertPt; + IRBuilder<> Builder(InsertPt); Value *CounterPtrArray = Builder.CreateConstInBoundsGEP2_64(EdgeTable, 0, i * ComplexEdgePreds.size()); -- GitLab