From 00216980fb655d4323e4a4394dfbebd72ae9a130 Mon Sep 17 00:00:00 2001 From: Chandler Carruth Date: Sun, 31 Jan 2010 10:26:25 +0000 Subject: [PATCH] Really trivial patch to accept pointer to const void in indirect goto. Despite the lack of documentation, this matches the behavior of GCC. llvm-svn: 94954 --- clang/lib/Sema/SemaStmt.cpp | 6 +++--- clang/test/Sema/indirect-goto.c | 3 +++ 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/clang/lib/Sema/SemaStmt.cpp b/clang/lib/Sema/SemaStmt.cpp index 7fefcf2764d5..a75003bf3f5d 100644 --- a/clang/lib/Sema/SemaStmt.cpp +++ b/clang/lib/Sema/SemaStmt.cpp @@ -906,10 +906,10 @@ Sema::ActOnIndirectGotoStmt(SourceLocation GotoLoc, SourceLocation StarLoc, Expr* E = DestExp.takeAs(); if (!E->isTypeDependent()) { QualType ETy = E->getType(); + QualType DestTy = Context.getPointerType(Context.VoidTy.withConst()); AssignConvertType ConvTy = - CheckSingleAssignmentConstraints(Context.VoidPtrTy, E); - if (DiagnoseAssignmentResult(ConvTy, StarLoc, Context.VoidPtrTy, ETy, - E, AA_Passing)) + CheckSingleAssignmentConstraints(DestTy, E); + if (DiagnoseAssignmentResult(ConvTy, StarLoc, DestTy, ETy, E, AA_Passing)) return StmtError(); } return Owned(new (Context) IndirectGotoStmt(GotoLoc, StarLoc, E)); diff --git a/clang/test/Sema/indirect-goto.c b/clang/test/Sema/indirect-goto.c index 134ccd8a7076..4c1c6c328a18 100644 --- a/clang/test/Sema/indirect-goto.c +++ b/clang/test/Sema/indirect-goto.c @@ -2,6 +2,9 @@ struct c {int x;}; int a(struct c x, long long y) { + void const* l1_ptr = &&l1; + goto *l1_ptr; +l1: goto *x; // expected-error{{incompatible type}} goto *y; // expected-warning{{incompatible integer to pointer conversion}} } -- GitLab