From 0e4513b030bdd53af547c20f8122cff9658e8686 Mon Sep 17 00:00:00 2001 From: Anna Zaks Date: Fri, 15 Mar 2013 23:34:31 +0000 Subject: [PATCH] [analyzer] Address a TODO in the StreamChecker; otherwise the output is non-deterministic. llvm-svn: 177207 --- clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp b/clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp index 1c38ab0b184d..ffdf2d54b4ce 100644 --- a/clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp +++ b/clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp @@ -400,9 +400,8 @@ void StreamChecker::checkDeadSymbols(SymbolReaper &SymReaper, SymbolRef Sym = *I; ProgramStateRef state = C.getState(); const StreamState *SS = state->get(Sym); - // TODO: Shouldn't we have a continue here? if (!SS) - return; + continue; if (SS->isOpened()) { ExplodedNode *N = C.generateSink(); -- GitLab