diff --git a/clang/lib/StaticAnalyzer/Core/PathDiagnostic.cpp b/clang/lib/StaticAnalyzer/Core/PathDiagnostic.cpp index 15a6635062ac512eb85d6a052bddceabd3f25ea9..d010a668d91550e64596073598bfc61b50b0dddc 100644 --- a/clang/lib/StaticAnalyzer/Core/PathDiagnostic.cpp +++ b/clang/lib/StaticAnalyzer/Core/PathDiagnostic.cpp @@ -208,41 +208,6 @@ void PathDiagnosticConsumer::HandlePathDiagnostic(PathDiagnostic *D) { namespace { - -static llvm::Optional comparePiece(PathDiagnosticPiece &X, - PathDiagnosticPiece &Y) { - PathDiagnosticPiece::Kind XK = X.getKind(), YK = Y.getKind(); - if (XK != YK) { - return XK < YK; - } - FullSourceLoc XL = X.getLocation().asLocation(); - FullSourceLoc YL = Y.getLocation().asLocation(); - if (XL < YL) - return true; - if (YL < XL) - return false; - const std::string &XS = X.getString(); - const std::string &YS = Y.getString(); - if (XS != YS) - return XS < YS; - return llvm::Optional(); -} - -static bool comparePathPieces(const PathPieces &X, const PathPieces &Y) { - if (X.size() < Y.size()) - return true; - if (X.size() > Y.size()) - return false; - // Compare individual parts of the path. - assert(X.size() == Y.size()); - for (unsigned i = 0, n = X.size(); i < n; ++i) { - llvm::Optional B = comparePiece(*X[i], *Y[i]); - if (B.hasValue()) - return B.getValue(); - } - return false; -} - struct CompareDiagnostics { // Compare if 'X' is "<" than 'Y'. bool operator()(const PathDiagnostic *X, const PathDiagnostic *Y) const { @@ -251,7 +216,7 @@ struct CompareDiagnostics { const FullSourceLoc &YLoc = Y->getLocation().asLocation(); if (XLoc < YLoc) return true; - if (YLoc < XLoc) + if (XLoc != YLoc) return false; // Next, compare by bug type. @@ -270,8 +235,8 @@ struct CompareDiagnostics { if (XDesc != YDesc) return false; - // Fall back to comparing path pieces. - return comparePathPieces(X->path, Y->path); + // FIXME: Further refine by comparing PathDiagnosticPieces? + return false; } }; } diff --git a/clang/test/Analysis/retain-release.m b/clang/test/Analysis/retain-release.m index ee7112443e43a04b0b5bf03bcaaa706e3075fd35..9638d64817523d2177f71ae9e79b9835549be09d 100644 --- a/clang/test/Analysis/retain-release.m +++ b/clang/test/Analysis/retain-release.m @@ -1924,6 +1924,7 @@ void test_CFPlugInInstanceCreate(CFUUIDRef factoryUUID, CFUUIDRef typeUUID) { } // CHECK: +// CHECK: // CHECK: diagnostics // CHECK-NEXT: // CHECK-NEXT: @@ -12751,44 +12752,10 @@ void test_CFPlugInInstanceCreate(CFUUIDRef factoryUUID, CFUUIDRef typeUUID) { // CHECK-NEXT: path // CHECK-NEXT: // CHECK-NEXT: -// CHECK-NEXT: kindcontrol -// CHECK-NEXT: edges -// CHECK-NEXT: -// CHECK-NEXT: -// CHECK-NEXT: start -// CHECK-NEXT: -// CHECK-NEXT: -// CHECK-NEXT: line838 -// CHECK-NEXT: col3 -// CHECK-NEXT: file0 -// CHECK-NEXT: -// CHECK-NEXT: -// CHECK-NEXT: line838 -// CHECK-NEXT: col3 -// CHECK-NEXT: file0 -// CHECK-NEXT: -// CHECK-NEXT: -// CHECK-NEXT: end -// CHECK-NEXT: -// CHECK-NEXT: -// CHECK-NEXT: line839 -// CHECK-NEXT: col3 -// CHECK-NEXT: file0 -// CHECK-NEXT: -// CHECK-NEXT: -// CHECK-NEXT: line839 -// CHECK-NEXT: col3 -// CHECK-NEXT: file0 -// CHECK-NEXT: -// CHECK-NEXT: -// CHECK-NEXT: -// CHECK-NEXT: -// CHECK-NEXT: -// CHECK-NEXT: // CHECK-NEXT: kindevent // CHECK-NEXT: location // CHECK-NEXT: -// CHECK-NEXT: line839 +// CHECK-NEXT: line838 // CHECK-NEXT: col3 // CHECK-NEXT: file0 // CHECK-NEXT: @@ -12796,12 +12763,12 @@ void test_CFPlugInInstanceCreate(CFUUIDRef factoryUUID, CFUUIDRef typeUUID) { // CHECK-NEXT: // CHECK-NEXT: // CHECK-NEXT: -// CHECK-NEXT: line839 +// CHECK-NEXT: line838 // CHECK-NEXT: col3 // CHECK-NEXT: file0 // CHECK-NEXT: // CHECK-NEXT: -// CHECK-NEXT: line839 +// CHECK-NEXT: line838 // CHECK-NEXT: col18 // CHECK-NEXT: file0 // CHECK-NEXT: @@ -12809,15 +12776,15 @@ void test_CFPlugInInstanceCreate(CFUUIDRef factoryUUID, CFUUIDRef typeUUID) { // CHECK-NEXT: // CHECK-NEXT: depth0 // CHECK-NEXT: extended_message -// CHECK-NEXT: Calling 'noCopyString' +// CHECK-NEXT: Calling 'NoCopyString' // CHECK-NEXT: message -// CHECK-NEXT: Calling 'noCopyString' +// CHECK-NEXT: Calling 'NoCopyString' // CHECK-NEXT: // CHECK-NEXT: // CHECK-NEXT: kindevent // CHECK-NEXT: location // CHECK-NEXT: -// CHECK-NEXT: line834 +// CHECK-NEXT: line833 // CHECK-NEXT: col1 // CHECK-NEXT: file0 // CHECK-NEXT: @@ -12835,12 +12802,12 @@ void test_CFPlugInInstanceCreate(CFUUIDRef factoryUUID, CFUUIDRef typeUUID) { // CHECK-NEXT: start // CHECK-NEXT: // CHECK-NEXT: -// CHECK-NEXT: line834 +// CHECK-NEXT: line833 // CHECK-NEXT: col1 // CHECK-NEXT: file0 // CHECK-NEXT: // CHECK-NEXT: -// CHECK-NEXT: line834 +// CHECK-NEXT: line833 // CHECK-NEXT: col1 // CHECK-NEXT: file0 // CHECK-NEXT: @@ -12848,12 +12815,12 @@ void test_CFPlugInInstanceCreate(CFUUIDRef factoryUUID, CFUUIDRef typeUUID) { // CHECK-NEXT: end // CHECK-NEXT: // CHECK-NEXT: -// CHECK-NEXT: line834 +// CHECK-NEXT: line833 // CHECK-NEXT: col30 // CHECK-NEXT: file0 // CHECK-NEXT: // CHECK-NEXT: -// CHECK-NEXT: line834 +// CHECK-NEXT: line833 // CHECK-NEXT: col35 // CHECK-NEXT: file0 // CHECK-NEXT: @@ -12869,12 +12836,12 @@ void test_CFPlugInInstanceCreate(CFUUIDRef factoryUUID, CFUUIDRef typeUUID) { // CHECK-NEXT: start // CHECK-NEXT: // CHECK-NEXT: -// CHECK-NEXT: line834 +// CHECK-NEXT: line833 // CHECK-NEXT: col30 // CHECK-NEXT: file0 // CHECK-NEXT: // CHECK-NEXT: -// CHECK-NEXT: line834 +// CHECK-NEXT: line833 // CHECK-NEXT: col35 // CHECK-NEXT: file0 // CHECK-NEXT: @@ -12882,12 +12849,12 @@ void test_CFPlugInInstanceCreate(CFUUIDRef factoryUUID, CFUUIDRef typeUUID) { // CHECK-NEXT: end // CHECK-NEXT: // CHECK-NEXT: -// CHECK-NEXT: line834 +// CHECK-NEXT: line833 // CHECK-NEXT: col37 // CHECK-NEXT: file0 // CHECK-NEXT: // CHECK-NEXT: -// CHECK-NEXT: line834 +// CHECK-NEXT: line833 // CHECK-NEXT: col37 // CHECK-NEXT: file0 // CHECK-NEXT: @@ -12899,7 +12866,7 @@ void test_CFPlugInInstanceCreate(CFUUIDRef factoryUUID, CFUUIDRef typeUUID) { // CHECK-NEXT: kindevent // CHECK-NEXT: location // CHECK-NEXT: -// CHECK-NEXT: line834 +// CHECK-NEXT: line833 // CHECK-NEXT: col37 // CHECK-NEXT: file0 // CHECK-NEXT: @@ -12907,12 +12874,12 @@ void test_CFPlugInInstanceCreate(CFUUIDRef factoryUUID, CFUUIDRef typeUUID) { // CHECK-NEXT: // CHECK-NEXT: // CHECK-NEXT: -// CHECK-NEXT: line834 +// CHECK-NEXT: line833 // CHECK-NEXT: col37 // CHECK-NEXT: file0 // CHECK-NEXT: // CHECK-NEXT: -// CHECK-NEXT: line834 +// CHECK-NEXT: line833 // CHECK-NEXT: col59 // CHECK-NEXT: file0 // CHECK-NEXT: @@ -12928,7 +12895,7 @@ void test_CFPlugInInstanceCreate(CFUUIDRef factoryUUID, CFUUIDRef typeUUID) { // CHECK-NEXT: kindevent // CHECK-NEXT: location // CHECK-NEXT: -// CHECK-NEXT: line839 +// CHECK-NEXT: line838 // CHECK-NEXT: col3 // CHECK-NEXT: file0 // CHECK-NEXT: @@ -12936,12 +12903,12 @@ void test_CFPlugInInstanceCreate(CFUUIDRef factoryUUID, CFUUIDRef typeUUID) { // CHECK-NEXT: // CHECK-NEXT: // CHECK-NEXT: -// CHECK-NEXT: line839 +// CHECK-NEXT: line838 // CHECK-NEXT: col3 // CHECK-NEXT: file0 // CHECK-NEXT: // CHECK-NEXT: -// CHECK-NEXT: line839 +// CHECK-NEXT: line838 // CHECK-NEXT: col18 // CHECK-NEXT: file0 // CHECK-NEXT: @@ -12949,9 +12916,43 @@ void test_CFPlugInInstanceCreate(CFUUIDRef factoryUUID, CFUUIDRef typeUUID) { // CHECK-NEXT: // CHECK-NEXT: depth1 // CHECK-NEXT: extended_message -// CHECK-NEXT: Returning from 'noCopyString' +// CHECK-NEXT: Returning from 'NoCopyString' // CHECK-NEXT: message -// CHECK-NEXT: Returning from 'noCopyString' +// CHECK-NEXT: Returning from 'NoCopyString' +// CHECK-NEXT: +// CHECK-NEXT: +// CHECK-NEXT: kindcontrol +// CHECK-NEXT: edges +// CHECK-NEXT: +// CHECK-NEXT: +// CHECK-NEXT: start +// CHECK-NEXT: +// CHECK-NEXT: +// CHECK-NEXT: line838 +// CHECK-NEXT: col3 +// CHECK-NEXT: file0 +// CHECK-NEXT: +// CHECK-NEXT: +// CHECK-NEXT: line838 +// CHECK-NEXT: col3 +// CHECK-NEXT: file0 +// CHECK-NEXT: +// CHECK-NEXT: +// CHECK-NEXT: end +// CHECK-NEXT: +// CHECK-NEXT: +// CHECK-NEXT: line839 +// CHECK-NEXT: col3 +// CHECK-NEXT: file0 +// CHECK-NEXT: +// CHECK-NEXT: +// CHECK-NEXT: line839 +// CHECK-NEXT: col3 +// CHECK-NEXT: file0 +// CHECK-NEXT: +// CHECK-NEXT: +// CHECK-NEXT: +// CHECK-NEXT: // CHECK-NEXT: // CHECK-NEXT: // CHECK-NEXT: kindcontrol @@ -23803,4 +23804,3 @@ void test_CFPlugInInstanceCreate(CFUUIDRef factoryUUID, CFUUIDRef typeUUID) { // CHECK-NEXT: // CHECK-NEXT: // CHECK-NEXT: -// CHECK-NEXT: \ No newline at end of file