From 309e48695b9533db3c6e37e15dd4ebc57a0dd351 Mon Sep 17 00:00:00 2001 From: Chris Lattner Date: Sat, 28 Feb 2009 19:37:57 +0000 Subject: [PATCH] Fix a crash in test/Parser/control-scope.c that testrunner didn't notice because it was a negative test with a fix suggested by Jean-Daniel Dupas. Convert the test from a negative to a positive test to catch stuff like this. llvm-svn: 65708 --- clang/lib/Sema/SemaDecl.cpp | 2 +- clang/test/Parser/control-scope.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/clang/lib/Sema/SemaDecl.cpp b/clang/lib/Sema/SemaDecl.cpp index 98b8dbc9c071..c9b5405fbe15 100644 --- a/clang/lib/Sema/SemaDecl.cpp +++ b/clang/lib/Sema/SemaDecl.cpp @@ -3497,7 +3497,7 @@ Sema::DeclTy *Sema::ActOnEnumConstant(Scope *S, DeclTy *theEnumDecl, else Diag(IdLoc, diag::err_redefinition) << Id; Diag(PrevDecl->getLocation(), diag::note_previous_definition); - Val->Destroy(Context); + if (Val) Val->Destroy(Context); return 0; } } diff --git a/clang/test/Parser/control-scope.c b/clang/test/Parser/control-scope.c index 3d588d63b4cc..4beed7eecd3d 100644 --- a/clang/test/Parser/control-scope.c +++ b/clang/test/Parser/control-scope.c @@ -1,8 +1,8 @@ -// RUN: not clang %s -std=c90 && +// RUN: clang %s -std=c90 -verify && // RUN: clang %s -std=c99 int f (int z) { - if (z + sizeof (enum {a})) - return 1 + sizeof (enum {a}); + if (z + sizeof (enum {a})) // expected-note {{previous definition is here}} + return 1 + sizeof (enum {a}); // expected-error {{redefinition of enumerator 'a'}} return 0; } -- GitLab