From 6306becc498a43217334820e6eb4e29b4c7cb089 Mon Sep 17 00:00:00 2001 From: Rafael Espindola Date: Mon, 5 Jun 2006 22:26:14 +0000 Subject: [PATCH] add R0 to liveout expand "ret null" (implements test/Regression/CodeGen/ARM/ret_void.ll) note that a Flag link is missing between the copy and the branch llvm-svn: 28691 --- llvm/lib/Target/ARM/ARMISelDAGToDAG.cpp | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/llvm/lib/Target/ARM/ARMISelDAGToDAG.cpp b/llvm/lib/Target/ARM/ARMISelDAGToDAG.cpp index 90ffab0158e2..ecf54aaa7954 100644 --- a/llvm/lib/Target/ARM/ARMISelDAGToDAG.cpp +++ b/llvm/lib/Target/ARM/ARMISelDAGToDAG.cpp @@ -49,18 +49,28 @@ static SDOperand LowerCALL(SDOperand Op, SelectionDAG &DAG) { static SDOperand LowerRET(SDOperand Op, SelectionDAG &DAG) { SDOperand Copy; + SDOperand Chain = Op.getOperand(0); switch(Op.getNumOperands()) { default: assert(0 && "Do not know how to return this many arguments!"); abort(); - case 1: - return SDOperand(); // ret void is legal + case 1: { + SDOperand LR = DAG.getRegister(ARM::R14, MVT::i32); + return DAG.getNode(ISD::BRIND, MVT::Other, Chain, LR); + } case 3: - Copy = DAG.getCopyToReg(Op.getOperand(0), ARM::R0, Op.getOperand(1), SDOperand()); + Copy = DAG.getCopyToReg(Chain, ARM::R0, Op.getOperand(1), SDOperand()); + if (DAG.getMachineFunction().liveout_empty()) + DAG.getMachineFunction().addLiveOut(ARM::R0); break; } + SDOperand LR = DAG.getRegister(ARM::R14, MVT::i32); + //bug: the copy and branch should be linked with a flag so that the + //scheduller can't move an instruction that destroys R0 in between them + //return DAG.getNode(ISD::BRIND, MVT::Other, Copy, LR, Copy.getValue(1)); + return DAG.getNode(ISD::BRIND, MVT::Other, Copy, LR); } -- GitLab