diff --git a/llvm/lib/Transforms/Scalar/InstructionCombining.cpp b/llvm/lib/Transforms/Scalar/InstructionCombining.cpp index 5631bd0ee008d74cc0404705ff02a2465f0830f1..661b0475cc59d25c399596e581766c7bc4360d92 100644 --- a/llvm/lib/Transforms/Scalar/InstructionCombining.cpp +++ b/llvm/lib/Transforms/Scalar/InstructionCombining.cpp @@ -2576,12 +2576,21 @@ Instruction *InstCombiner::visitMul(BinaryOperator &I) { } else if (isa(Op1->getType())) { if (isa(Op1)) return ReplaceInstUsesWith(I, Op1); - - // As above, vector X*splat(1.0) -> X in all defined cases. - if (ConstantVector *Op1V = dyn_cast(Op1)) - if (ConstantFP *F = dyn_cast_or_null(Op1V->getSplatValue())) - if (F->isExactlyValue(1.0)) - return ReplaceInstUsesWith(I, Op0); + + if (ConstantVector *Op1V = dyn_cast(Op1)) { + if (Op1V->isAllOnesValue()) // X * -1 == 0 - X + return BinaryOperator::CreateNeg(Op0, I.getName()); + + // As above, vector X*splat(1.0) -> X in all defined cases. + if (Constant *Splat = Op1V->getSplatValue()) { + if (ConstantFP *F = dyn_cast(Splat)) + if (F->isExactlyValue(1.0)) + return ReplaceInstUsesWith(I, Op0); + if (ConstantInt *CI = dyn_cast(Splat)) + if (CI->equalsInt(1)) + return ReplaceInstUsesWith(I, Op0); + } + } } if (BinaryOperator *Op0I = dyn_cast(Op0)) @@ -2856,6 +2865,13 @@ Instruction *InstCombiner::commonIDivTransforms(BinaryOperator &I) { if (I.getType() == Type::Int1Ty) return ReplaceInstUsesWith(I, Op0); + if (ConstantVector *Op1V = dyn_cast(Op1)) { + if (ConstantInt *X = cast_or_null(Op1V->getSplatValue())) + // div X, 1 == X + if (X->isOne()) + return ReplaceInstUsesWith(I, Op0); + } + return 0; } diff --git a/llvm/test/Transforms/InstCombine/2008-11-27-IDivVector.ll b/llvm/test/Transforms/InstCombine/2008-11-27-IDivVector.ll new file mode 100644 index 0000000000000000000000000000000000000000..4275e1191a88b566325707a254142ad77672f735 --- /dev/null +++ b/llvm/test/Transforms/InstCombine/2008-11-27-IDivVector.ll @@ -0,0 +1,11 @@ +; RUN: llvm-as < %s | opt -instcombine | llvm-dis | not grep div + +define <2 x i8> @f(<2 x i8> %x) { + %A = udiv <2 x i8> %x, + ret <2 x i8> %A +} + +define <2 x i8> @g(<2 x i8> %x) { + %A = sdiv <2 x i8> %x, + ret <2 x i8> %A +} diff --git a/llvm/test/Transforms/InstCombine/2008-11-27-MultiplyIntVec.ll b/llvm/test/Transforms/InstCombine/2008-11-27-MultiplyIntVec.ll new file mode 100644 index 0000000000000000000000000000000000000000..544e9abbbcb7424f880166315a113333384b2f01 --- /dev/null +++ b/llvm/test/Transforms/InstCombine/2008-11-27-MultiplyIntVec.ll @@ -0,0 +1,11 @@ +; RUN: llvm-as < %s | opt -instcombine | llvm-dis | not grep mul + +define <2 x i8> @f(<2 x i8> %x) { + %A = mul <2 x i8> %x, + ret <2 x i8> %A +} + +define <2 x i8> @g(<2 x i8> %x) { + %A = mul <2 x i8> %x, + ret <2 x i8> %A +}