diff --git a/llvm/include/llvm/MC/MCAsmLexer.h b/llvm/include/llvm/MC/MCAsmLexer.h index da471d284ccf740a3c4b626266f26b76c5d4ae26..e9a6e3fda4ae4e386b242803c1ae49899b5d30a2 100644 --- a/llvm/include/llvm/MC/MCAsmLexer.h +++ b/llvm/include/llvm/MC/MCAsmLexer.h @@ -20,7 +20,8 @@ class SMLoc; class Target; /// AsmToken - Target independent representation for an assembler token. -struct AsmToken { +class AsmToken { +public: enum TokenKind { // Markers Eof, Error, diff --git a/llvm/include/llvm/MC/MCParsedAsmOperand.h b/llvm/include/llvm/MC/MCParsedAsmOperand.h index 7c9e9e65c1e57c0888bcebdfc3c8101eac0e4204..847ab43f44d57b1079d3167962c12c6d81fdcba7 100644 --- a/llvm/include/llvm/MC/MCParsedAsmOperand.h +++ b/llvm/include/llvm/MC/MCParsedAsmOperand.h @@ -18,8 +18,8 @@ namespace llvm { /// between parsing an asm instruction and recognizing it. class MCParsedAsmOperand { public: - MCParsedAsmOperand(); - virtual ~MCParsedAsmOperand() = 0; + MCParsedAsmOperand() {} + virtual ~MCParsedAsmOperand() {} // TODO: Out of line vfun. }; diff --git a/llvm/include/llvm/Target/TargetAsmParser.h b/llvm/include/llvm/Target/TargetAsmParser.h index ef1fc49cefee5202dbd183b109215f6a910049eb..a265610f2f2a61444f5c8f395940a7254054dd84 100644 --- a/llvm/include/llvm/Target/TargetAsmParser.h +++ b/llvm/include/llvm/Target/TargetAsmParser.h @@ -10,13 +10,13 @@ #ifndef LLVM_TARGET_TARGETPARSER_H #define LLVM_TARGET_TARGETPARSER_H -#include "llvm/MC/MCAsmLexer.h" - namespace llvm { class MCAsmParser; class MCInst; class StringRef; class Target; +class SMLoc; +class AsmToken; /// TargetAsmParser - Generic interface to target specific assembly parsers. class TargetAsmParser { @@ -45,7 +45,8 @@ public: /// \param Name - The instruction name. /// \param Inst [out] - On success, the parsed instruction. /// \return True on failure. - virtual bool ParseInstruction(const StringRef &Name, MCInst &Inst) = 0; + virtual bool ParseInstruction(const StringRef &Name, SMLoc NameLoc, + MCInst &Inst) = 0; /// ParseDirective - Parse a target specific assembler directive /// diff --git a/llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp b/llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp index db776850464043524323d84ee96ac00fe0161d7d..9288384508c626b7456d79faac61cc8153a66030 100644 --- a/llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp +++ b/llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp @@ -95,7 +95,8 @@ public: ARMAsmParser(const Target &T, MCAsmParser &_Parser) : TargetAsmParser(T), Parser(_Parser) {} - virtual bool ParseInstruction(const StringRef &Name, MCInst &Inst); + virtual bool ParseInstruction(const StringRef &Name, SMLoc NameLoc, + MCInst &Inst); virtual bool ParseDirective(AsmToken DirectiveID); }; @@ -579,7 +580,8 @@ bool ARMAsmParser::ParseOperand(ARMOperand &Op) { } /// Parse an arm instruction mnemonic followed by its operands. -bool ARMAsmParser::ParseInstruction(const StringRef &Name, MCInst &Inst) { +bool ARMAsmParser::ParseInstruction(const StringRef &Name, SMLoc NameLoc, + MCInst &Inst) { SmallVector Operands; Operands.push_back(ARMOperand::CreateToken(Name)); diff --git a/llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp b/llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp index 1237c45c5f948896fb5e00b2e8ff64ade78e60da..d431aa67957890d7f46596282f77ad2a7c82f568 100644 --- a/llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp +++ b/llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp @@ -60,7 +60,8 @@ public: X86ATTAsmParser(const Target &T, MCAsmParser &_Parser) : TargetAsmParser(T), Parser(_Parser) {} - virtual bool ParseInstruction(const StringRef &Name, MCInst &Inst); + virtual bool ParseInstruction(const StringRef &Name, SMLoc NameLoc, + MCInst &Inst); virtual bool ParseDirective(AsmToken DirectiveID); }; @@ -401,7 +402,8 @@ bool X86ATTAsmParser::ParseMemOperand(X86Operand &Op) { return false; } -bool X86ATTAsmParser::ParseInstruction(const StringRef &Name, MCInst &Inst) { +bool X86ATTAsmParser::ParseInstruction(const StringRef &Name, + SMLoc NameLoc, MCInst &Inst) { SmallVector Operands; Operands.push_back(X86Operand::CreateToken(Name)); diff --git a/llvm/tools/llvm-mc/AsmParser.cpp b/llvm/tools/llvm-mc/AsmParser.cpp index 1204a0054afa7e29bac62f6f33b085696b45da4a..4ef3a7fc3559ef99826e208cf895446c0bca371f 100644 --- a/llvm/tools/llvm-mc/AsmParser.cpp +++ b/llvm/tools/llvm-mc/AsmParser.cpp @@ -711,7 +711,7 @@ bool AsmParser::ParseStatement() { } MCInst Inst; - if (getTargetParser().ParseInstruction(IDVal, Inst)) + if (getTargetParser().ParseInstruction(IDVal, IDLoc, Inst)) return true; if (Lexer.isNot(AsmToken::EndOfStatement))