From b2c4ca64334599762d840ebd396090ac4bd076af Mon Sep 17 00:00:00 2001 From: Rafael Espindola Date: Mon, 4 Oct 2010 18:44:25 +0000 Subject: [PATCH] Produce a R_X86_64_GOT32 when needed. llvm-svn: 115537 --- llvm/lib/MC/ELFObjectWriter.cpp | 13 ++++++++++++- llvm/test/MC/ELF/got.s | 14 ++++++++++++++ 2 files changed, 26 insertions(+), 1 deletion(-) create mode 100644 llvm/test/MC/ELF/got.s diff --git a/llvm/lib/MC/ELFObjectWriter.cpp b/llvm/lib/MC/ELFObjectWriter.cpp index 7e0ce7d711ef..c7b862f3928a 100644 --- a/llvm/lib/MC/ELFObjectWriter.cpp +++ b/llvm/lib/MC/ELFObjectWriter.cpp @@ -576,6 +576,8 @@ void ELFObjectWriterImpl::RecordRelocation(const MCAssembler &Asm, FixedValue = Value; // determine the type of the relocation + + MCSymbolRefExpr::VariantKind Modifier = Target.getSymA()->getKind(); unsigned Type; if (Is64Bit) { if (IsPCRel) { @@ -587,7 +589,16 @@ void ELFObjectWriterImpl::RecordRelocation(const MCAssembler &Asm, case X86::reloc_signed_4byte: case X86::reloc_pcrel_4byte: assert(isInt<32>(Target.getConstant())); - Type = ELF::R_X86_64_32S; + switch (Modifier) { + case MCSymbolRefExpr::VK_None: + Type = ELF::R_X86_64_32S; + break; + case MCSymbolRefExpr::VK_GOT: + Type = ELF::R_X86_64_GOT32; + break; + default: + llvm_unreachable("Unimplemented"); + } break; case FK_Data_4: Type = ELF::R_X86_64_32; diff --git a/llvm/test/MC/ELF/got.s b/llvm/test/MC/ELF/got.s new file mode 100644 index 000000000000..c44245d078b2 --- /dev/null +++ b/llvm/test/MC/ELF/got.s @@ -0,0 +1,14 @@ +// RUN: llvm-mc -filetype=obj -triple x86_64-pc-linux-gnu %s -o - | elf-dump | FileCheck %s + +// Test that this produces a R_X86_64_GOT32. + + movl foo@GOT, %eax + +// CHECK: ('_relocations', [ +// CHECK-NEXT: # Relocation 0 +// CHECK-NEXT: (('r_offset', +// CHECK-NEXT: ('r_sym', +// CHECK-NEXT: ('r_type', 3) +// CHECK-NEXT: ('r_addend', +// CHECK-NEXT: ), +// CHECK-NEXT: ]) -- GitLab