From cfa3e287bb4169ca8584a51e0ce20f71606395aa Mon Sep 17 00:00:00 2001 From: Bill Wendling Date: Mon, 10 Nov 2008 23:38:59 +0000 Subject: [PATCH] Small simplification. Use the iterator already present as the insertion point. llvm-svn: 59008 --- llvm/lib/CodeGen/StackProtector.cpp | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/llvm/lib/CodeGen/StackProtector.cpp b/llvm/lib/CodeGen/StackProtector.cpp index 386c7cd162a1..746addeba44e 100644 --- a/llvm/lib/CodeGen/StackProtector.cpp +++ b/llvm/lib/CodeGen/StackProtector.cpp @@ -148,16 +148,15 @@ bool StackProtector::InsertStackProtectors() { FailBB = CreateFailBB(); } - Function::iterator InsPt = BB; ++InsPt; // Insertion point for new BB. ++I; // Skip to the next block so that we don't resplit the return block. // Split the basic block before the return instruction. BasicBlock *NewBB = BB->splitBasicBlock(RI, "SP_return"); - // Move the newly created basic block to the point right after the old basic - // block so that it's in the "fall through" position. + // Move the newly created basic block to the point right after the old + // basic block so that it's in the "fall through" position. NewBB->removeFromParent(); - F->getBasicBlockList().insert(InsPt, NewBB); + F->getBasicBlockList().insert(I, NewBB); // Generate the stack protector instructions in the old basic block. LoadInst *LI1 = new LoadInst(StackGuardVar, "", false, BB); -- GitLab