From e69f72493517b940c6c40824ca8356c208bba15a Mon Sep 17 00:00:00 2001 From: Jim Grosbach Date: Fri, 10 Dec 2010 21:05:07 +0000 Subject: [PATCH] Fix encoding of 'U' bit for Thumb2 STRD/LDRD instructions. rdar://8755726 llvm-svn: 121524 --- llvm/lib/Target/ARM/ARMMCCodeEmitter.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/llvm/lib/Target/ARM/ARMMCCodeEmitter.cpp b/llvm/lib/Target/ARM/ARMMCCodeEmitter.cpp index bf869f703bcb..df28a9929136 100644 --- a/llvm/lib/Target/ARM/ARMMCCodeEmitter.cpp +++ b/llvm/lib/Target/ARM/ARMMCCodeEmitter.cpp @@ -552,9 +552,9 @@ getAddrModeImm12OpValue(const MCInst &MI, unsigned OpIdx, uint32_t ARMMCCodeEmitter:: getT2AddrModeImm8s4OpValue(const MCInst &MI, unsigned OpIdx, SmallVectorImpl &Fixups) const { - // {17-13} = reg - // {12} = (U)nsigned (add == '1', sub == '0') - // {11-0} = imm8 + // {12-9} = reg + // {8} = (U)nsigned (add == '1', sub == '0') + // {7-0} = imm8 unsigned Reg, Imm8; bool isAdd = true; // If The first operand isn't a register, we have a label reference. @@ -576,7 +576,7 @@ getT2AddrModeImm8s4OpValue(const MCInst &MI, unsigned OpIdx, uint32_t Binary = (Imm8 >> 2) & 0xff; // Immediate is always encoded as positive. The 'U' bit controls add vs sub. if (isAdd) - Binary |= (1 << 9); + Binary |= (1 << 8); Binary |= (Reg << 9); return Binary; } -- GitLab