- Jan 07, 2013
-
-
Chandler Carruth authored
a TargetMachine to construct (and thus isn't always available), to an analysis group that supports layered implementations much like AliasAnalysis does. This is a pretty massive change, with a few parts that I was unable to easily separate (sorry), so I'll walk through it. The first step of this conversion was to make TargetTransformInfo an analysis group, and to sink the nonce implementations in ScalarTargetTransformInfo and VectorTargetTranformInfo into a NoTargetTransformInfo pass. This allows other passes to add a hard requirement on TTI, and assume they will always get at least on implementation. The TargetTransformInfo analysis group leverages the delegation chaining trick that AliasAnalysis uses, where the base class for the analysis group delegates to the previous analysis *pass*, allowing all but tho NoFoo analysis passes to only implement the parts of the interfaces they support. It also introduces a new trick where each pass in the group retains a pointer to the top-most pass that has been initialized. This allows passes to implement one API in terms of another API and benefit when some other pass above them in the stack has more precise results for the second API. The second step of this conversion is to create a pass that implements the TargetTransformInfo analysis using the target-independent abstractions in the code generator. This replaces the ScalarTargetTransformImpl and VectorTargetTransformImpl classes in lib/Target with a single pass in lib/CodeGen called BasicTargetTransformInfo. This class actually provides most of the TTI functionality, basing it upon the TargetLowering abstraction and other information in the target independent code generator. The third step of the conversion adds support to all TargetMachines to register custom analysis passes. This allows building those passes with access to TargetLowering or other target-specific classes, and it also allows each target to customize the set of analysis passes desired in the pass manager. The baseline LLVMTargetMachine implements this interface to add the BasicTTI pass to the pass manager, and all of the tools that want to support target-aware TTI passes call this routine on whatever target machine they end up with to add the appropriate passes. The fourth step of the conversion created target-specific TTI analysis passes for the X86 and ARM backends. These passes contain the custom logic that was previously in their extensions of the ScalarTargetTransformInfo and VectorTargetTransformInfo interfaces. I separated them into their own file, as now all of the interface bits are private and they just expose a function to create the pass itself. Then I extended these target machines to set up a custom set of analysis passes, first adding BasicTTI as a fallback, and then adding their customized TTI implementations. The fourth step required logic that was shared between the target independent layer and the specific targets to move to a different interface, as they no longer derive from each other. As a consequence, a helper functions were added to TargetLowering representing the common logic needed both in the target implementation and the codegen implementation of the TTI pass. While technically this is the only change that could have been committed separately, it would have been a nightmare to extract. The final step of the conversion was just to delete all the old boilerplate. This got rid of the ScalarTargetTransformInfo and VectorTargetTransformInfo classes, all of the support in all of the targets for producing instances of them, and all of the support in the tools for manually constructing a pass based around them. Now that TTI is a relatively normal analysis group, two things become straightforward. First, we can sink it into lib/Analysis which is a more natural layer for it to live. Second, clients of this interface can depend on it *always* being available which will simplify their code and behavior. These (and other) simplifications will follow in subsequent commits, this one is clearly big enough. Finally, I'm very aware that much of the comments and documentation needs to be updated. As soon as I had this working, and plausibly well commented, I wanted to get it committed and in front of the build bots. I'll be doing a few passes over documentation later if it sticks. Commits to update DragonEgg and Clang will be made presently. llvm-svn: 171681
-
Nico Weber authored
llvm-svn: 171680
-
Michael Gottesman authored
[ObjCARC Debug Message] - Added debug message when fuse a retain/autorelease pair in ObjCARCContract::ContractAutorelease. llvm-svn: 171679
-
Michael Gottesman authored
[ObjCARC Debug Message] - Added debug message when we zap a matching retain/autorelease pair in ObjCARCOpt::OptimizeReturns. llvm-svn: 171678
-
Michael Gottesman authored
[ObjCARC Debug Message] - Added debug message when we erase ARC calls with null since they are no-ops. llvm-svn: 171677
-
Michael Gottesman authored
[ObjCARC Debug Message] - Added debug message when we add a nounwind keyword to a function which can not throw. llvm-svn: 171676
-
Michael Gottesman authored
[ObjCARC Debug Message] - Added debug message when we add a tail keyword to a function which can never be passed stack args. llvm-svn: 171675
-
- Jan 06, 2013
-
-
Michael Gottesman authored
llvm-svn: 171674
-
Michael Gottesman authored
Added debug statement to ObjCARC when we replace objc_autorelease(x) with objc_release(x) when x is otherwise unused. llvm-svn: 171673
-
Michael Gottesman authored
Added 2x Debug statements to ObjCARC that log when we handle the two undefined pointer-to-weak-pointer is NULL cases by replacing the given call inst with an undefined value. The reason that there are two cases is that the first case handles the unary cases and the second the binary cases. llvm-svn: 171672
-
Dmitri Gribenko authored
is actually used by a few Linux distributions llvm-svn: 171671
-
Michael Gottesman authored
Added debug message in ObjCARC when we remove a no-op cast which has only special semantic meaning in the frontend and thus in the optimizer can be deleted. llvm-svn: 171670
-
Michael Gottesman authored
Added debug message to ObjCARC when we transform an objc_autoreleaseReturnValue => objc_autorelease due to its operand not being used as a return value. llvm-svn: 171669
-
Craig Topper authored
Fix suffix handling for parsing and printing of cvtsi2ss, cvtsi2sd, cvtss2si, cvttss2si, cvtsd2si, and cvttsd2si to match gas behavior. cvtsi2* should parse with an 'l' or 'q' suffix or no suffix at all. No suffix should be treated the same as 'l' suffix. Printing should always print a suffix. Previously we didn't parse or print an 'l' suffix. cvtt*2si/cvt*2si should parse with an 'l' or 'q' suffix or not suffix at all. No suffix should use the destination register size to choose encoding. Printing should not print a suffix. Original 'l' suffix issue with cvtsi2* pointed out by Michael Kuperstein. llvm-svn: 171668
-
Dmitri Gribenko authored
these ideas don't get lost llvm-svn: 171667
-
Manuel Klimek authored
If we find an unexpected closing brace, we must not stop parsing, as we'd otherwise not layout anything beyond that point. If we find a structural error on the highest level we'll not re-indent anyway, but we'll still want to format within unwrapped lines. Needed to introduce a differentiation between an expected and unexpected closing brace. llvm-svn: 171666
-
Evan Cheng authored
Fix for PR14739. It's not safe to fold a load into a call across a store. Thanks to Nick Lewycky for the initial patch. llvm-svn: 171665
-
Dmitri Gribenko authored
This is coming up again and again on the mailing list and IRC. llvm-svn: 171656
-
Sylvestre Ledru authored
llvm-svn: 171655
-
Sean Silva authored
llvm-svn: 171654
-
Andrew Trick authored
Indirect branch in the preheader crashes replaceCongruentIVs. Fixes rdar://12910141. llvm-svn: 171653
-
Michael J. Spencer authored
llvm-svn: 171652
-
Michael J. Spencer authored
llvm-svn: 171651
-
Michael J. Spencer authored
llvm-svn: 171650
-
Michael J. Spencer authored
This currently prints the ELF program headers. llvm-svn: 171649
-
Michael J. Spencer authored
llvm-svn: 171648
-
Michael J. Spencer authored
llvm-svn: 171647
-
Michael J. Spencer authored
llvm-svn: 171645
-
Renato Golin authored
Signed-off-by:
Renato Golin <renato.golin@linaro.org> llvm-svn: 171642
-
- Jan 05, 2013
-
-
Manuel Klimek authored
To parse # correctly, we need to know whether it is the first token in a line - we can deduct this either from the whitespace or seeing that the token is the first in the file - we already calculate this information. This patch moves the identification of the first token into the getNextToken method and stores it inside the FormatToken, so the UnwrappedLineParser can stay independent of the SourceManager. llvm-svn: 171640
-
Manuel Klimek authored
Uses indent 0 for macros for now and resets the indent state to the level prior to the preprocessor directive. llvm-svn: 171639
-
Fariborz Jahanian authored
<objc/Protocol.h>. Caused by my recent changes for various builtin declarations of objc_msgSendSuper variety. // rdar://12489098 llvm-svn: 171638
-
David Blaikie authored
Based on code review feedback for r171604 from Chandler Carruth & Eric Christopher. Enabled by improvements to LLVM made in r171636. llvm-svn: 171637
-
David Blaikie authored
Based on code review feedback in r171604 from Chandler Carruth & Eric Christopher. llvm-svn: 171636
-
Manuel Klimek authored
A preprocessor directive cannot be started while we're parsing one. llvm-svn: 171635
-
David Blaikie authored
Catch some cases I'd missed in r171605 related to unnamed parameters of record type. This resolves all remaining cases of PR14573 suppression in the GDB 7.5 test suite. Fix to the test suite to follow. llvm-svn: 171633
-
David Blaikie authored
A rather egregious example of the grep-style checking of old that I randomly came across. llvm-svn: 171631
-
Dmitri Gribenko authored
'clang' to use it as the compiler. llvm-svn: 171630
-
Michael Gottesman authored
Added debug message to ObjCARC when we transform objc_retainAutorelasedReturnValue => objc_retain since the operand to said function is not a return value. llvm-svn: 171629
-
Michael Gottesman authored
Added debug message for ObjCARC when we zap an objc_autoreleaseReturnValue/objc_retainAutoreleasedValue pair. llvm-svn: 171628
-