From 07630933bc9831ec94954a588fda9febca10ae23 Mon Sep 17 00:00:00 2001 From: Reid Kleckner Date: Thu, 29 May 2014 17:12:05 +0000 Subject: [PATCH] [ADT] Delete the Twine assignment operator This makes it slightly harder to misuse Twines. It is still possible to refer to destroyed temporaries with the regular constructors, though. Patch by Marco Alesiani! llvm-svn: 209832 --- llvm/include/llvm/ADT/Twine.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/llvm/include/llvm/ADT/Twine.h b/llvm/include/llvm/ADT/Twine.h index a54fd743ad68..4be3ee6f82db 100644 --- a/llvm/include/llvm/ADT/Twine.h +++ b/llvm/include/llvm/ADT/Twine.h @@ -182,6 +182,10 @@ namespace llvm { assert(isValid() && "Invalid twine!"); } + /// Since the intended use of twines is as temporary objects, assignments + /// when concatenating might cause undefined behavior or stack corruptions + Twine &operator=(const Twine &Other) LLVM_DELETED_FUNCTION; + /// isNull - Check for the null twine. bool isNull() const { return getLHSKind() == NullKind; -- GitLab