diff --git a/llvm/lib/Transforms/Scalar/LICM.cpp b/llvm/lib/Transforms/Scalar/LICM.cpp index 5d49a02342313021ee8d87029bab043fc344b1b7..2d6f6cecafeaf5e2799361d4297d44e2643e7e62 100644 --- a/llvm/lib/Transforms/Scalar/LICM.cpp +++ b/llvm/lib/Transforms/Scalar/LICM.cpp @@ -1009,6 +1009,21 @@ bool llvm::promoteLoopAccessesToScalars(AliasSet &AS, if (!GuaranteedToExecute) return Changed; + // Figure out the loop exits and their insertion points, if this is the + // first promotion. + if (ExitBlocks.empty()) { + CurLoop->getUniqueExitBlocks(ExitBlocks); + InsertPts.clear(); + InsertPts.reserve(ExitBlocks.size()); + for (BasicBlock *ExitBlock : ExitBlocks) { + // Can't insert into a catchswitch. + if (isa(ExitBlock->getTerminator())) + return Changed; + + InsertPts.push_back(&*ExitBlock->getFirstInsertionPt()); + } + } + // Otherwise, this is safe to promote, lets do it! DEBUG(dbgs() << "LICM: Promoting value stored to in loop: " <<*SomePtr<<'\n'); Changed = true; @@ -1020,15 +1035,6 @@ bool llvm::promoteLoopAccessesToScalars(AliasSet &AS, // location is better than none. DebugLoc DL = LoopUses[0]->getDebugLoc(); - // Figure out the loop exits and their insertion points, if this is the - // first promotion. - if (ExitBlocks.empty()) { - CurLoop->getUniqueExitBlocks(ExitBlocks); - InsertPts.resize(ExitBlocks.size()); - for (unsigned i = 0, e = ExitBlocks.size(); i != e; ++i) - InsertPts[i] = &*ExitBlocks[i]->getFirstInsertionPt(); - } - // We use the SSAUpdater interface to insert phi nodes as required. SmallVector NewPHIs; SSAUpdater SSA(&NewPHIs); diff --git a/llvm/test/Transforms/LICM/funclet.ll b/llvm/test/Transforms/LICM/funclet.ll index 4052ef7c4d7038dc5cd9da7528e007a9fe0cf859..10001526ffc93972e465cbd8b31ed90ab67fc71b 100644 --- a/llvm/test/Transforms/LICM/funclet.ll +++ b/llvm/test/Transforms/LICM/funclet.ll @@ -60,6 +60,42 @@ try.cont: ; preds = %catch, %while.cond ; CHECK-NEXT: store i32 %[[CALL]], i32* %s ; CHECK-NEXT: cleanupret from %[[CP]] unwind to caller +define void @test3(i1 %a, i1 %b, i1 %c) personality i32 (...)* @__CxxFrameHandler3 { +entry: + %.frame = alloca i8, align 4 + %bc = bitcast i8* %.frame to i32* + br i1 %a, label %try.success.or.caught, label %forbody + +catch.object.Throwable: ; preds = %catch.dispatch + %cp = catchpad within %cs [i8* null, i32 64, i8* null] + unreachable + +try.success.or.caught: ; preds = %forcond.backedge, %0 + ret void + +postinvoke: ; preds = %forbody + br i1 %b, label %else, label %forcond.backedge + +forcond.backedge: ; preds = %else, %postinvoke + br i1 %c, label %try.success.or.caught, label %forbody + +catch.dispatch: ; preds = %else, %forbody + %cs = catchswitch within none [label %catch.object.Throwable] unwind to caller + +forbody: ; preds = %forcond.backedge, %0 + store i32 1, i32* %bc, align 4 + invoke void @may_throw() + to label %postinvoke unwind label %catch.dispatch + +else: ; preds = %postinvoke + invoke void @may_throw() + to label %forcond.backedge unwind label %catch.dispatch +} + +; CHECK-LABEL: define void @test3( +; CHECK: catchswitch within none +; CHECK: store i32 1, i32* %bc, align 4 + declare void @may_throw() declare i32 @pure_computation() nounwind argmemonly readonly