From b4e55f392390a6c37541f996a4497b1806d54b90 Mon Sep 17 00:00:00 2001 From: Philip Reames Date: Thu, 10 Sep 2015 00:32:56 +0000 Subject: [PATCH] [RewriteStatepointsForGC] Strengthen a confusingly weak assertion [NFC] The assertion was weaker than it should be and gave the impression we're growing the number of base defining values being considered during the fixed point interation. That's not true. The tighter form of the assert is useful documentation. llvm-svn: 247221 --- llvm/lib/Transforms/Scalar/RewriteStatepointsForGC.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/llvm/lib/Transforms/Scalar/RewriteStatepointsForGC.cpp b/llvm/lib/Transforms/Scalar/RewriteStatepointsForGC.cpp index 22baeddc1a59..57687def2d9e 100644 --- a/llvm/lib/Transforms/Scalar/RewriteStatepointsForGC.cpp +++ b/llvm/lib/Transforms/Scalar/RewriteStatepointsForGC.cpp @@ -797,7 +797,7 @@ static Value *findBasePointer(Value *I, DefiningValueMapTy &cache) { bool progress = true; while (progress) { #ifndef NDEBUG - size_t oldSize = States.size(); + const size_t oldSize = States.size(); #endif progress = false; // We're only changing values in this loop, thus safe to keep iterators. @@ -842,8 +842,8 @@ static Value *findBasePointer(Value *I, DefiningValueMapTy &cache) { } } - assert(oldSize <= States.size()); - assert(oldSize == States.size() || progress); + assert(oldSize == States.size() && + "fixed point shouldn't be adding any new nodes to state"); } #ifndef NDEBUG -- GitLab