-
Logan Smith authored
Try enabling -Wsuggest-override again, using add_compile_options instead of add_compile_definitions for disabling it in unittests/ directories. Using add_compile_definitions caused the flag to be passed to rc.exe on Windows and thus broke Windows builds.
Logan Smith authoredTry enabling -Wsuggest-override again, using add_compile_options instead of add_compile_definitions for disabling it in unittests/ directories. Using add_compile_definitions caused the flag to be passed to rc.exe on Windows and thus broke Windows builds.
Loading