Skip to content
  • David Bolvansky's avatar
    [Inliner] Attribute callsites with inline remarks · 7c0537a3
    David Bolvansky authored
    Summary:
    Sometimes reading an output *.ll file it is not easy to understand why some callsites are not inlined. We can read output of inline remarks (option --pass-remarks-missed=inline) and try correlating its messages with the callsites.
    
    An easier way proposed by this patch is to add to every callsite processed by Inliner an attribute with the latest message that describes the cause of not inlining this callsite. The attribute is called //inline-remark//. By default this feature is off. It can be switched on by the option //-inline-remark-attribute//.
    
    For example in the provided test the result method //@test1// has two callsites //@bar// and inline remarks report different inlining missed reasons:
      remark: <unknown>:0:0: bar not inlined into test1 because too costly to inline (cost=-5, threshold=-6)
      remark: <unknown>:0:0: bar not inlined into test1 because it should never be inlined (cost=never): recursive
    
    It is not clear which remark correspond to which callsite. With the inline remark attribute enabled we get the reasons attached to their callsites:
      define void @test1() {
        call void @bar(i1 true) #0
        call void @bar(i1 false) #2
        ret void
      }
      attributes #0 = { "inline-remark"="(cost=-5, threshold=-6)" }
      ..
      attributes #2 = { "inline-remark"="(cost=never): recursive" }
    
    Patch by: yrouban (Yevgeny Rouban)
    
    Reviewers: xbolva00, tejohnson, apilipenko
    
    Reviewed By: xbolva00, tejohnson
    
    Subscribers: eraman, llvm-commits
    
    Differential Revision: https://reviews.llvm.org/D50435
    
    llvm-svn: 340618
    7c0537a3
Loading