Skip to content
  • Arthur Eubanks's avatar
    [NewPM][Inliner] Check if deleted function is in current SCC · 8bc298d0
    Arthur Eubanks authored
    In weird cases, the inliner will inline internal recursive functions,
    sometimes causing them to have no more uses, in which case the
    inliner will mark the function to be deleted. The function is
    actually deleted after the call to
    updateCGAndAnalysisManagerForCGSCCPass(). In
    updateCGAndAnalysisManagerForCGSCCPass(), UR.UpdatedC may be set to
    the SCC containing the function to be deleted. Then the inliner calls
    CG.removeDeadFunction() which can cause that SCC to be deleted, even
    though it's still stored in UR.UpdatedC.
    
    We could potentially check in the wrappers/pass managers if UR.UpdatedC
    is in UR.InvalidatedSCCs before doing anything with it, but it's safer
    to do this as close to possible to the call to CG.removeDeadFunction()
    to avoid issues with allocating a new SCC in the same address as
    the deleted one.
    
    It's hard to find a small test case since we need to have recursive
    internal functions be reachable from non-internal functions, yet they
    need to become non-recursive and not referenced by other functions when
    inlined.
    
    Similar to https://reviews.llvm.org/D106306.
    
    Fixes PR50788.
    
    Reviewed By: asbirlea
    
    Differential Revision: https://reviews.llvm.org/D106405
    8bc298d0
Loading