Skip to content
  • Chandler Carruth's avatar
    Change where we enable the heuristic that delays inlining into functions · 30b8416d
    Chandler Carruth authored
    which are small enough to themselves be inlined. Delaying in this manner
    can be harmful if the function is inelligible for inlining in some (or
    many) contexts as it pessimizes the code of the function itself in the
    event that inlining does not eventually happen.
    
    Previously the check was written to only do this delaying of inlining
    for static functions in the hope that they could be entirely deleted and
    in the knowledge that all callers of static functions will have the
    opportunity to inline if it is in fact profitable. However, with C++ we
    get two other important sources of functions where the definition is
    always available for inlining: inline functions and templated functions.
    This patch generalizes the inliner to allow linkonce-ODR (the linkage
    such C++ routines receive) to also qualify for this delay-based
    inlining.
    
    Benchmarking across a range of large real-world applications shows
    roughly 2% size increase across the board, but an average speedup of
    about 0.5%. Some benhcmarks improved over 2%, and the 'clang' binary
    itself (when bootstrapped with this feature) shows a 1% -O0 performance
    improvement when run over all Sema, Lex, and Parse source code smashed
    into a single file. A clean re-build of Clang+LLVM with a bootstrapped
    Clang shows approximately 2% improvement, but that measurement is often
    noisy.
    
    llvm-svn: 152737
    30b8416d
Loading