Skip to content
  • Chandler Carruth's avatar
    [PM] Fix a really nasty bug introduced when adding PGO support to the · b698d596
    Chandler Carruth authored
    new PM's inliner.
    
    The bug happens when we refine an SCC after having computed a proxy for
    the FunctionAnalysisManager, and then proceed to compute fresh analyses
    for functions in the *new* SCC using the manager provided by the old
    SCC's proxy. *And* when we manage to mutate a function in this new SCC
    in a way that invalidates those analyses. This can be... challenging to
    reproduce.
    
    I've managed to contrive a set of functions that trigger this and added
    a test case, but it is a bit brittle. I've directly checked that the
    passes run in the expected ways to help avoid the test just becoming
    silently irrelevant.
    
    This gets the new PM back to passing the LLVM test suite after the PGO
    improvements landed.
    
    llvm-svn: 292757
    b698d596
Loading