Skip to content
  • Kostya Kortchinsky's avatar
    c74da7ce
    Corrected D27428: Do not use the alignment-rounded-up size with secondary · c74da7ce
    Kostya Kortchinsky authored
    Summary:
    I atually had an integer overflow on 32-bit with D27428 that didn't reproduce
    locally, as the test servers would manage allocate addresses in the 0xffffxxxx
    range, which led to some issues when rounding addresses.
    
    At this point, I feel that Scudo could benefit from having its own combined
    allocator, as we don't get any benefit from the current one, but have to work
    around some hurdles (alignment checks, rounding up that is no longer needed,
    extraneous code).
    
    Reviewers: kcc, alekseyshl
    
    Subscribers: llvm-commits, kubabrecka
    
    Differential Revision: https://reviews.llvm.org/D27681
    
    llvm-svn: 289572
    c74da7ce
    Corrected D27428: Do not use the alignment-rounded-up size with secondary
    Kostya Kortchinsky authored
    Summary:
    I atually had an integer overflow on 32-bit with D27428 that didn't reproduce
    locally, as the test servers would manage allocate addresses in the 0xffffxxxx
    range, which led to some issues when rounding addresses.
    
    At this point, I feel that Scudo could benefit from having its own combined
    allocator, as we don't get any benefit from the current one, but have to work
    around some hurdles (alignment checks, rounding up that is no longer needed,
    extraneous code).
    
    Reviewers: kcc, alekseyshl
    
    Subscribers: llvm-commits, kubabrecka
    
    Differential Revision: https://reviews.llvm.org/D27681
    
    llvm-svn: 289572
Loading