Wdeprecated: StoredDiagnostics are stored in a SmallVector, so make sure they're copy/movable

Removing the no-op dtor makes these objects safely implicitly
copyable/movable/etc.

(& tidy up the ctor, while I'm here)

llvm-svn: 244971