[flang] Fix source positions during parse tree rewriting
When a StmtFunctionStmt was rewritten as an array element assignment the subscripts were not getting correct source locations. They need to be copied from the function args. Also, the entire array element expression (e.g. `a(i)`) did not have a source position. This was tricky because there is no source position in the original parse that matches what we need. So we take the source position from the beginning of the function name to the end of the last arg and extend it one more character to include the closing parenthesis. Change `ActualArgToExpr()` to return `Expr` rather than `std::optional<Expr>` because callers always call `.value()` on the result anyway. Add `WithSource()` utility to update the `source` data member of a parse tree node. This bug shows up as incorrect source positions for error messages. For example, in this program the error (due to real subscript) did not have a source position: ``` real :: a(10), x, y a(x) = y end ``` Original-commit: flang-compiler/f18@a9bcf68cebe16341e918700ce223baaf66ed441a Reviewed-on: https://github.com/flang-compiler/f18/pull/433
Loading
Please sign in to comment