[MinGW] Don't currently set visibility=hidden when building for MinGW
If we build the Target libraries with -fvisibility=hidden, then LLVM_EXTERNAL_VISIBILITY must also be able to override it back to default visibility. Currently, the LLVM_EXTERNAL_VISIBILITY define is a no-op for mingw targets, thus set CMAKE_CXX_VISIBILITY_PRESET correspondingly. This unbreaks the mingw dylib build, if the compiler actually takes hidden visiblity into account (e.g. after D130121). (Later, once hidden visiblity can be used for MinGW targets, we can make LLVM_EXTERNAL_VISIBILITY and LLVM_LIBRARY_VISIBILITY expand to actual attributes, and reverse this commit.) Differential Revision: https://reviews.llvm.org/D130200
Loading
Please sign in to comment