[gcov] Fix simultaneous .gcda creation/lock
Fixes PR45673 The commit 9180c14f (D76206) resolved only a part of the problem of concurrent .gcda file creation. It ensured that only one process creates the file but did not ensure that the process locks the file first. If not, the process which created the file may clobber the contents written by a process which locked the file first. This is the cause of PR45673. This commit prevents the clobbering by revising the assumption that a process which creates the file locks the file first. Regardless of file creation, a process which locked the file first uses fwrite (new_file==1) and other processes use mmap (new_file==0). I also tried to keep the creation/first-lock process same by using mkstemp/link/unlink but the code gets long. This commit is more simple. Note: You may be confused with other changes which try to resolve concurrent file access. My understanding is (may not be correct): D76206: Resolve race of .gcda file creation (but not lock) This one: Resolve race of .gcda file creation and lock D54599: Same as D76206 but abandoned? D70910: Resolve race of multi-threaded counter flushing D74953: Resolve counter sharing between parent/children processes D78477: Revision of D74953 Differential Revision: https://reviews.llvm.org/D79556
Loading
Please register or sign in to comment