[MLIR] Make MLIR cmake variable names consistent
Fix inconsistent MLIR CMake variable names. Consistently name them as MLIR_ENABLE_<feature>. Eg: MLIR_CUDA_RUNNER_ENABLED -> MLIR_ENABLE_CUDA_RUNNER MLIR follows (or has mostly followed) the convention of naming cmake enabling variables in the from MLIR_ENABLE_... etc. Using a convention here is easy and also important for convenience. A counter pattern was started with variables named MLIR_..._ENABLED. This led to a sequence of related counter patterns: MLIR_CUDA_RUNNER_ENABLED, MLIR_ROCM_RUNNER_ENABLED, etc.. From a naming standpoint, the imperative form is more meaningful. Additional discussion at: https://llvm.discourse.group/t/mlir-cmake-enable-variable-naming-convention/3520 Switch all inconsistent ones to the ENABLE form. Keep the couple of old mappings needed until buildbot config is migrated. Differential Revision: https://reviews.llvm.org/D102976
Showing
- mlir/CMakeLists.txt 29 additions, 15 deletionsmlir/CMakeLists.txt
- mlir/cmake/modules/AddMLIRPython.cmake 1 addition, 1 deletionmlir/cmake/modules/AddMLIRPython.cmake
- mlir/docs/Bindings/Python.md 2 additions, 2 deletionsmlir/docs/Bindings/Python.md
- mlir/docs/SPIRVToLLVMDialectConversion.md 1 addition, 1 deletionmlir/docs/SPIRVToLLVMDialectConversion.md
- mlir/docs/Tools/LinalgOpDsl.md 1 addition, 1 deletionmlir/docs/Tools/LinalgOpDsl.md
- mlir/lib/Bindings/CMakeLists.txt 1 addition, 1 deletionmlir/lib/Bindings/CMakeLists.txt
- mlir/lib/Conversion/GPUCommon/CMakeLists.txt 2 additions, 2 deletionsmlir/lib/Conversion/GPUCommon/CMakeLists.txt
- mlir/lib/Dialect/GPU/CMakeLists.txt 5 additions, 5 deletionsmlir/lib/Dialect/GPU/CMakeLists.txt
- mlir/lib/ExecutionEngine/CMakeLists.txt 2 additions, 2 deletionsmlir/lib/ExecutionEngine/CMakeLists.txt
- mlir/test/CMakeLists.txt 13 additions, 13 deletionsmlir/test/CMakeLists.txt
- mlir/test/lit.site.cfg.py.in 7 additions, 7 deletionsmlir/test/lit.site.cfg.py.in
Loading
Please register or sign in to comment