Partially revert '[MachO] Update embedded part of ObjectFileMachO for Mangled API change'
Commit f3aa9e36 fixed the embedded OS build by removing all passed args for `GetName`/`GetDemangledName`. The motivation for this was that these arguments were apparently removed in commit 22b04487. However, only `GetName`'s language argument was removed but the mangling preference argument was *not* removed (and unfortunately had a default argument). So when that commit removed all the args it didn't just fix the build but it also changed all the mangling preferences to 'demangled' for all `GetName` calls. Also some `GetName` calls were outside the TARGET_OS_EMBEDDED ifdef, so this change ended up breaking the following tests on macOS: lldb-api :: lang/objc/objc-static-method-stripped/TestObjCStaticMethodStripped.py lldb-api :: lang/objc/objc-super/TestObjCSuper.py From what I can see f3aa9e36 removed 12 ePreferMangled args and this patch re-adds 12 args with roughly the same line numbers, so this *should* restore the old behaviour and also keep the embedded build working. On the other hand, ObjectFileMachO::ParseSymtab is a very successful attempt at writing the longest possible function within LLVM, so this fix is partly based on the engineering principle known as "hoping for the best".
Loading
Please register or sign in to comment