Skip to content
  1. Dec 18, 2015
    • Jonathan Peyton's avatar
      [STATS] Have CMake do real check for stats functionality · b9e83260
      Jonathan Peyton authored
      This change allows clang to build the stats library for every architecture
      which supports __builtin_readcyclecounter().  CMake also checks for all
      necessary features for stats and will error out if the platform does not
      support it.
      
      Patch by Hal Finkel and Johnny Peyton
      
      llvm-svn: 256002
      b9e83260
  2. Nov 30, 2015
    • Jonathan Peyton's avatar
      Adding Hwloc library option for affinity mechanism · 01dcf36b
      Jonathan Peyton authored
      These changes allow libhwloc to be used as the topology discovery/affinity
      mechanism for libomp.  It is supported on Unices. The code additions:
      * Canonicalize KMP_CPU_* interface macros so bitmask operations are
        implementation independent and work with both hwloc bitmaps and libomp
        bitmaps.  So there are new KMP_CPU_ALLOC_* and KMP_CPU_ITERATE() macros and
        the like. These are all in kmp.h and appropriately placed.
      * Hwloc topology discovery code in kmp_affinity.cpp. This uses the hwloc
        interface to create a libomp address2os object which the rest of libomp knows
        how to handle already.
      * To build, use -DLIBOMP_USE_HWLOC=on and
        -DLIBOMP_HWLOC_INSTALL_DIR=/path/to/install/dir [default /usr/local]. If CMake
        can't find the library or hwloc.h, then it will tell you and exit.
      
      Differential Revision: http://reviews.llvm.org/D13991
      
      llvm-svn: 254320
      01dcf36b
  3. Nov 05, 2015
    • Jonathan Peyton's avatar
      Improve OMPT initialization code · 95246e7d
      Jonathan Peyton authored
      Use of #ifdef OMPT_DEBUG was causing messages to be generated under normal
      operation when the OpenMP library was compiled with KMP_DEBUG enabled.
      Elsewhere, KMP_DEBUG evaluates assertions, but never produces messages during
      normal operation. To avoid this inconsistency, set OMPT_DEBUG using a cmake
      variable LIBOMP_OMPT_DEBUG.
      
      While I was editing the associated ompt-specific.h and ompt-general.c files,
      make the spacing and comments consistent.
      
      Patch by John Mellor-Crummey
      
      Differential Revision: http://reviews.llvm.org/D14355
      
      llvm-svn: 252173
      95246e7d
  4. Oct 29, 2015
    • Jonathan Peyton's avatar
      [OMPT] Windows Support for OMPT · 69e596a5
      Jonathan Peyton authored
      The problem is that the ompt_tool() function (which must be implemented by a
      performance tool) should be defined in the RTL as well to cover the case when
      the tool is not present in the address space of the process. This functionality
      is accomplished with weak symbols in Unices. Unfortunately, Windows does not
      support weak symbols.
      
      The solution in these changes is to grab the list of all modules loaded by the
      process and then search for symbol "ompt_tool()" within them. The function
      ompt_tool_windows() performs the search of the ompt_tool symbol. If ompt_tool is
      found, then its return value is used to initialize the tool. If ompt_tool is not
      found, then ompt_tool_windows() returns NULL and OMPT is thus, disabled.
      
      While doing these changes, the OMPT_SUPPORT detection in CMake was changed to
      test for the required featuers for OMPT_SUPPORT, namely: builtin_frame_address()
      existence, weak attribute existence and psapi.dll existence. For
      LIBOMP_HAVE_OMPT_SUPPORT to be true, it must be that the builtin_frame_address()
      intrinsic exists AND one of: either weak attributes exist or psapi.dll exists.
      
      Also, since Process Status API is used I had to add new dependency -- psapi.dll
      to the library dependency micro test.
      
      Differential Revision: http://reviews.llvm.org/D14027
      
      llvm-svn: 251654
      69e596a5
  5. Sep 21, 2015
    • Jonathan Peyton's avatar
      OpenMP Initial testsuite change to purely llvm-lit based testing · 614c7ef8
      Jonathan Peyton authored
      This change introduces a check-libomp target which is based upon llvm's lit
      test infrastructure. Each test (generated from the University of Houston's
      OpenMP testsuite) is compiled and then run. For each test, an exit status of 0
      indicates success and non-zero indicates failure. This way, FileCheck is not
      needed. I've added a bit of logic to generate symlinks (libiomp5 and libgomp)
      in the build tree so that gcc can be tested as well.  When building out-of-
      tree builds, the user will have to provide llvm-lit either by specifying
      -DLIBOMP_LLVM_LIT_EXECUTABLE or having llvm-lit in their PATH.
      
      Differential Revision: http://reviews.llvm.org/D11821
      
      llvm-svn: 248211
      614c7ef8
  6. Aug 28, 2015
    • Jonathan Peyton's avatar
      [OpenMP] [CMake] Removing expand-vars.pl in favor of CMake's configure_file() · c0225ca2
      Jonathan Peyton authored
      Currently, the libomp CMake build system uses a Perl script to configure files
      (tools/expand-vars.pl). This patch replaces the use of the Perl script by using
      CMake's configure_file() function. The major changes include:
      1. *.var has every $KMP_* variable changed to @LIBOMP_*@
      2. kmp_config.h.cmake is a new file which contains all the feature macros and
         #cmakedefine lines
      3. Most of the -D lines have been moved from LibompDefinitions.cmake but some
         OS specific MACROs (e.g., _GNU_SOURCE) remain.
      4. All expand-vars.pl related logic is removed from the CMake files.
      
      One important note about this change is that it breaks the old Perl+Makefile
      build system because it can't create kmp_config.h properly.
      
      Differential Review: http://reviews.llvm.org/D12211
      
      llvm-svn: 246314
      c0225ca2
  7. Aug 11, 2015
    • Jonathan Peyton's avatar
      Tidy statistics collection · 45be4500
      Jonathan Peyton authored
      This removes some statistics counters and timers which were not used,
      adds new counters and timers for some language features that were not
      monitored previously and separates the counters and timers into those
      which are of interest for investigating user code and those which are
      only of interest to the developer of the runtime itself.
      The runtime developer statistics are now ony collected if the
      additional #define KMP_DEVELOPER_STATS is set.
      
      Additional user statistics which are now collected include:
      * Count of nested parallelism (omp parallel inside a parallel region)
      * Count of omp distribute occurrences
      * Count of omp teams occurrences
      * Counts of task related statistics (taskyield, task execution, task
        cancellation, task steal)
      * Values passed to omp_set_numtheads
      * Time spent in omp single and omp master
      
      None of this affects code compiled without stats gathering enabled,
      which is the normal library build mode.
      
      This also fixes the CMake build by linking to the standard c++ library
      when building the stats library as it is a requirement.  The normal library
      does not have this requirement and its link phase is left alone.
      
      Differential Revision: http://reviews.llvm.org/D11759
      
      llvm-svn: 244677
      45be4500
  8. Jul 18, 2015
    • Chandler Carruth's avatar
      [cmake] Support enabling -Werror in the OpenMP runtime CMake build and · 5145156a
      Chandler Carruth authored
      clean up the build.
      
      This disables all of the Clang warnings that fire for me when building
      libomp.so on Linux with a recent Clang binary. Lots of these should
      probably be fixed, but I want to at least get the build warning-clean
      and make it easy to keep that way.
      
      I also switched a bunch of the warnings that are used both for C and C++
      compiles to check the flag with C compilation test.
      
      Differential Revision: http://reviews.llvm.org/D11253
      
      llvm-svn: 242604
      5145156a
  9. Jul 15, 2015
    • Jonathan Peyton's avatar
      Re-indent the CMake refactor to two-space indention · 5b4acbd6
      Jonathan Peyton authored
      I apologize for this nasty commit, but I somehow overlooked Chandler's
      comment to re-indent these files to two space indention.  I know this
      is a horrible commit, but I figured if it was done quickly after the 
      first one, not too many conflicts would arise.
      
      Again, I'm sorry and won't do this again.
      
      llvm-svn: 242301
      5b4acbd6
    • Jonathan Peyton's avatar
      Large Refactor of CMake build system · 2e013352
      Jonathan Peyton authored
      This commit improves numerous functionalities of the OpenMP CMake build 
      system to be more conducive with LLVM's build system and build philosophies.
      The CMake build system, as it was before this commit, was not up to LLVM's 
      standards and did not implement the configuration stage like most CMake based
      build systems offer (check for compiler flags, libraries, etc.) In order to
      improve it dramatically in a short period of time, a large refactoring had 
      to be done.
      The main changes done with this commit are as follows:
      
      * Compiler flag checks - The flags are no longer grabbed from compiler specific
        directories.  They are checked for availability in config-ix.cmake and added
        accordingly inside LibompHandleFlags.cmake.
      * Feature checks were added in config-ix.cmake.  For example, the standard CMake
        module FindThreads is probed for the threading model to use inside the OpenMP
        library.
      * OS detection - There is no longer a LIBOMP_OS variable, OS-specifc build logic
        is wrapped around the WIN32 and APPLE macros with !(WIN32 OR APPLE) meaning 
        a Unix flavor of some sort.
      * Got rid of vestigial functions/macros/variables
      * Added new libomp_append() function which is used everywhere to conditionally
        or undconditionally append to a list
      * All targets have the libomp prefix so as not to interfere with any other
        project
      * LibompCheckLinkerFlag.cmake module was added which checks for linker flags
        specifically for building shared libraries.
      * LibompCheckFortranFlag.cmake module was added which checks for fortran flag
        availability.
      * Removed most of the cruft from the translation between the perl+Makefile based
        build system and this one.  The remaining components that they share are
        perl scripts which I'm in the process of removing.
      
      There is still more left to do.  The perl scripts still need to be removed, and
      a config.h.in file (or similarly named) needs to be added with #cmakedefine lines
      in it.  But this is a much better first step than the previous system.
      
      Differential Revision: http://reviews.llvm.org/D10656
      
      llvm-svn: 242298
      2e013352
  10. Jul 09, 2015
    • Jonathan Peyton's avatar
      Turn debugger interface off by default. · 3bbcb4d7
      Jonathan Peyton authored
      Just changed LIBOMP_USE_DEBUGGER to false.
      
      llvm-svn: 241852
      3bbcb4d7
    • Jonathan Peyton's avatar
      Enable debugger support · 8fbb49ab
      Jonathan Peyton authored
      These changes enable external debuggers to conveniently interface with 
      the LLVM OpenMP Library.  Structures are added which describe the important
      internal structures of the OpenMP Library e.g., teams, threads, etc.
      This feature is turned on by default (CMake variable LIBOMP_USE_DEBUGGER)
      and can be turned off with -DLIBOMP_USE_DEBUGGER=off.
      
      Differential Revision: http://reviews.llvm.org/D10038
      
      llvm-svn: 241832
      8fbb49ab
  11. Jun 17, 2015
  12. Jun 11, 2015
    • Jonathan Peyton's avatar
      Remove unused variables '__kmp_build_check_*' for non assert builds. · 9919dfc3
      Jonathan Peyton authored
      Add new LIBOMP_ENABLE_ASSERTIONS macro which can be set in a standalone build
      or takes the value of LLVM_ENABLE_ASSERTIONS when inside llvm/projects.  This
      change also defines the KMP_BUILD_ASSERT() macro to do nothing when ENABLE_ASSERTIONS
      is off.  This means the __kmp_build_check_* types won't be defined and thus, no warnings.
      http://lists.cs.uiuc.edu/pipermail/openmp-dev/2015-June/000719.html
      
      Patch by Jack Howarth and Jonathan Peyton
      
      llvm-svn: 239546
      9919dfc3
    • Jonathan Peyton's avatar
      Implement recursive CMake. · 5215890c
      Jonathan Peyton authored
      Most CMake build systems put CMakeLists.txt files inside source directories where 
      items need to get built. This change follows that convention by adding a new 
      runtime/src/CMakeLists.txt file. An additional benefit is this helps logically 
      seperate configuring with building as well. This change is mostly just copying and 
      pasting the bottom half of runtime/CMakeLists.txt into runtime/src/CMakeLists.txt, 
      but a few changes had to be made to get it to work. Most of those changes were to 
      directory prefixes.
      
      Differential Revision: http://reviews.llvm.org/D10344
      
      llvm-svn: 239542
      5215890c
  13. Jun 01, 2015
    • Jonathan Peyton's avatar
      Apply name change to CMake build system. · 227e1aeb
      Jonathan Peyton authored
      This change has the CMake build system create a dynamic library named
      libomp instead of libiomp5.  Also any reference to libiomp is replaced
      with libomp.  One can still use the LIBOMP_LIB_NAME variable to enforce
      a different name, and everything will still work as expected.  An important
      note is that libiomp5 and libgomp symlinks are created at install time when
      on Unix systems.  On Windows, copies are created with the legacy names.
      
      llvm-svn: 238715
      227e1aeb
  14. May 29, 2015
  15. May 26, 2015
  16. May 21, 2015
    • Jonathan Peyton's avatar
      Change CMake variable prefix to LIBOMP · 7979a076
      Jonathan Peyton authored
      Cached CMake variables need to have a prefix so they don't collide with other
      projects. This change (a lot of simple changes) simply prefixes cached variables
      with LIBOMP_ and sets all of these variables to UPPERCASE which is convention.
      e.g., os => LIBOMP_OS, ompt_support => LIBOMP_OMPT_SUPPORT.
      
      Differential Revision: http://reviews.llvm.org/D9829
      
      llvm-svn: 237845
      7979a076
  17. May 14, 2015
  18. May 12, 2015
  19. May 07, 2015
  20. May 05, 2015
    • Andrey Churbanov's avatar
      Integrate libiomp CMake into LLVM CMake build system. · 648467ed
      Andrey Churbanov authored
      This patch integrates the libiomp CMake build system into the LLVM CMake build 
      system so that users can checkout libiomp into the projects directory of llvm 
      and build llvm,clang, and libiomp all together.  These changes specifically 
      introduce a new install target which will put libraries and headers into the 
      correct locations when either a standalone build or part of llvm.
      The copy_recipe() method has been removed in favor of the POST_BUILD method 
      to move headers into the exports subdirectory.  And lastly, the MicroTests.cmake 
      file was refactored which led to simpler target dependencies and a new target, 
      make libiomp-micro-tests, which performs the 5 small tests (test-relo, 
      test-touch, etc.) when called.
      
      llvm-svn: 236534
      648467ed
  21. Apr 29, 2015
  22. Feb 25, 2015
  23. Jan 19, 2015
  24. Jan 16, 2015
  25. Jan 13, 2015
  26. Oct 07, 2014
    • Jim Cownie's avatar
      I apologise in advance for the size of this check-in. At Intel we do · 4cc4bb4c
      Jim Cownie authored
      understand that this is not friendly, and are working to change our
      internal code-development to make it easier to make development
      features available more frequently and in finer (more functional)
      chunks. Unfortunately we haven't got that in place yet, and unpicking
      this into multiple separate check-ins would be non-trivial, so please
      bear with me on this one. We should be better in the future.
      
      Apologies over, what do we have here?
      
      GGC 4.9 compatibility
      --------------------
      * We have implemented the new entrypoints used by code compiled by GCC
      4.9 to implement the same functionality in gcc 4.8. Therefore code
      compiled with gcc 4.9 that used to work will continue to do so.
      However, there are some other new entrypoints (associated with task
      cancellation) which are not implemented. Therefore user code compiled
      by gcc 4.9 that uses these new features will not link against the LLVM
      runtime. (It remains unclear how to handle those entrypoints, since
      the GCC interface has potentially unpleasant performance implications
      for join barriers even when cancellation is not used)
      
      --- new parallel entry points ---
      new entry points that aren't OpenMP 4.0 related
      These are implemented fully :-
            GOMP_parallel_loop_dynamic()
            GOMP_parallel_loop_guided()
            GOMP_parallel_loop_runtime()
            GOMP_parallel_loop_static()
            GOMP_parallel_sections()
            GOMP_parallel()
      
      --- cancellation entry points ---
      Currently, these only give a runtime error if OMP_CANCELLATION is true
      because our plain barriers don't check for cancellation while waiting
              GOMP_barrier_cancel()
              GOMP_cancel()
              GOMP_cancellation_point()
              GOMP_loop_end_cancel()
              GOMP_sections_end_cancel()
      
      --- taskgroup entry points ---
      These are implemented fully.
            GOMP_taskgroup_start()
            GOMP_taskgroup_end()
      
      --- target entry points ---
      These are empty (as they are in libgomp)
           GOMP_target()
           GOMP_target_data()
           GOMP_target_end_data()
           GOMP_target_update()
           GOMP_teams()
      
      Improvements in Barriers and Fork/Join
      --------------------------------------
      * Barrier and fork/join code is now in its own file (which makes it
      easier to understand and modify).
      * Wait/release code is now templated and in its own file; suspend/resume code is also templated
      * There's a new, hierarchical, barrier, which exploits the
      cache-hierarchy of the Intel(r) Xeon Phi(tm) coprocessor to improve
      fork/join and barrier performance.
      
      ***BEWARE*** the new source files have *not* been added to the legacy
      Cmake build system. If you want to use that fixes wil be required.
      
      Statistics Collection Code
      --------------------------
      * New code has been added to collect application statistics (if this
      is enabled at library compile time; by default it is not). The
      statistics code itself is generally useful, the lightweight timing
      code uses the X86 rdtsc instruction, so will require changes for other
      architectures.
      The intent of this code is not for users to tune their codes but
      rather 
      1) For timing code-paths inside the runtime
      2) For gathering general properties of OpenMP codes to focus attention
      on which OpenMP features are most used. 
      
      Nested Hot Teams
      ----------------
      * The runtime now maintains more state to reduce the overhead of
      creating and destroying inner parallel teams. This improves the
      performance of code that repeatedly uses nested parallelism with the
      same resource allocation. Set the new KMP_HOT_TEAMS_MAX_LEVEL
      envirable to a depth to enable this (and, of course, OMP_NESTED=true
      to enable nested parallelism at all).
      
      Improved Intel(r) VTune(Tm) Amplifier support
      ---------------------------------------------
      * The runtime provides additional information to Vtune via the
      itt_notify interface to allow it to display better OpenMP specific
      analyses of load-imbalance.
      
      Support for OpenMP Composite Statements
      ---------------------------------------
      * Implement new entrypoints required by some of the OpenMP 4.1
      composite statements.
      
      Improved ifdefs
      ---------------
      * More separation of concepts ("Does this platform do X?") from
      platforms ("Are we compiling for platform Y?"), which should simplify
      future porting.
      
      
      ScaleMP* contribution
      ---------------------
      Stack padding to improve the performance in their environment where
      cross-node coherency is managed at the page level.
      
      Redesign of wait and release code
      ---------------------------------
      The code is simplified and performance improved.
      
      Bug Fixes
      ---------
          *Fixes for Windows multiple processor groups.
          *Fix Fortran module build on Linux: offload attribute added.
          *Fix entry names for distribute-parallel-loop construct to be consistent with the compiler codegen.
          *Fix an inconsistent error message for KMP_PLACE_THREADS environment variable.
      
      llvm-svn: 219214
      4cc4bb4c
  27. Aug 07, 2014
  28. Aug 05, 2014
    • Jim Cownie's avatar
      After three iterations of community review, we believe that this new · 3b81ce6b
      Jim Cownie authored
      CMAKE buld system should meet everyone's requirements.
      
      Enhanced CMake Build System Commit 
      
      * Supports Linux, Mac, Windows, and Intel® Xeon Phi builds
      * Supports building with gcc, icc, clang, and Visual Studio compilers
      * Supports bulding "fat" libraries on OS/X with clang
      * Details and documentation on how to use build system 
        are in Build_With_CMake.txt
      * To use the old CMake build system (corresponds to 
        CMakeLists.txt.old), just rename CMakeLists.txt to
        CMakeLists.txt.other and rename CMakeLists.txt.old to
        CMakeLists.txt
      
      llvm-svn: 214850
      3b81ce6b
  29. Jun 01, 2014
    • Alp Toker's avatar
      Add initial CMake build system · 7198f529
      Alp Toker authored
      This is not yet supported for production builds but can already produce working
      binaries on OS X and Linux with clang and gcc.
      
      The intention is to improve support to the point where it can integrate with
      the LLVM runtime platform, cover all platforms, runtime/release build
      configurations and run the tests.
      
      Patch by Jack Howarth!
      
      llvm-svn: 209994
      7198f529
Loading