Skip to content
  1. Feb 01, 2022
    • Christian Kühnel's avatar
      [clangd] Cleanup of readability-identifier-naming · 8edfc2f8
      Christian Kühnel authored
      Auto-generated patch based on clang-tidy readability-identifier-naming.
      Only some manual cleanup for `extern "C"` declarations and a GTest change was required.
      
      I'm not sure if this cleanup is actually very useful. It cleans up clang-tidy findings to the number of warnings from clang-tidy should be lower.  Since it was easy to do and required only little cleanup I thought I'd upload it for discussion.
      
      One pattern that keeps recurring: Test **matchers** are also supposed to start with a lowercase letter as per LLVM convention. However GTest naming convention for matchers start with upper case. I would propose to keep stay consistent with the GTest convention there. However that would imply a lot of `//NOLINT` throughout these files.
      
      To re-product this patch run:
      ```
      run-clang-tidy -checks="-*,readability-identifier-naming" -fix -format ./clang-tools-extra/clangd
      ```
      
      To convert the macro names, I was using this script with some manual cleanup afterwards:
      https://gist.github.com/ChristianKuehnel/a01cc4362b07c58281554ab46235a077
      
      Differential Revision: https://reviews.llvm.org/D115634
      8edfc2f8
  2. Jan 24, 2022
  3. Jan 03, 2022
  4. Jun 08, 2021
  5. Jan 31, 2020
  6. Feb 01, 2019
    • Ilya Biryukov's avatar
      Disable tidy checks with too many hits · d226bc83
      Ilya Biryukov authored
      Summary:
      Some tidy checks have too many hits in the codebase, making it hard to spot
      other results from clang-tidy, therefore rendering the tool less useful.
      
      Two checks were disabled:
        - misc-non-private-member-variable-in-classes in the whole LLVM monorepo,
          it is very common to have those in LLVM and the style guide does not forbid
          them.
        - readability-identifier-naming in the clang subtree. There are thousands of
          violations in 'Sema.h' alone.
      
      Before the change, 'Sema.h' had >1000 tidy warnings, after the change the number
      dropped to 3 warnings (unterminated namespace comments).
      
      Reviewers: alexfh, hokein
      
      Reviewed By: hokein
      
      Subscribers: llvm-commits, cfe-commits
      
      Tags: #clang, #llvm
      
      Differential Revision: https://reviews.llvm.org/D57573
      
      llvm-svn: 352862
      d226bc83
  7. Jan 29, 2019
  8. Mar 20, 2018
  9. Apr 13, 2016
  10. Oct 29, 2014
  11. Sep 08, 2014
Loading