Skip to content
  1. Dec 29, 2007
  2. Dec 25, 2007
    • Gordon Henriksen's avatar
      GC poses hazards to the inliner. Consider: · b969c598
      Gordon Henriksen authored
          define void @f() {
                  ...
                  call i32 @g()
                  ...
          }
      
          define void @g() {
                  ...
          }
      
      The hazards are:
      
        - @f and @g have GC, but they differ GC. Inlining is invalid. This
          may never occur.
        - @f has no GC, but @g does. g's GC must be propagated to @f.
      
      The other scenarios are safe:
      
        - @f and @g have the same GC.
        - @f and @g have no GC.
        - @g has no GC.
      
      This patch adds inliner checks for the former two scenarios.
      
      llvm-svn: 45351
      b969c598
  3. Dec 22, 2007
  4. Dec 19, 2007
  5. Dec 18, 2007
  6. Dec 17, 2007
  7. Dec 16, 2007
    • Duncan Sands's avatar
      Revert this part of r45073 until the verifier is · 56ed4803
      Duncan Sands authored
      changed not to reject invoke of inline asm.
      
      llvm-svn: 45077
      56ed4803
    • Duncan Sands's avatar
      Make instcombine promote inline asm calls to 'nounwind' · 8e4847ee
      Duncan Sands authored
      calls.  Remove special casing of inline asm from the
      inliner.  There is a potential problem: the verifier
      rejects invokes of inline asm (not sure why).  If an
      asm call is not marked "nounwind" in some .ll, and
      instcombine is not run, but the inliner is run, then
      an illegal module will be created.  This is bad but
      I'm not sure what the best approach is.  I'm tempted
      to remove the check in the verifier...
      
      llvm-svn: 45073
      8e4847ee
  8. Dec 10, 2007
    • Chris Lattner's avatar
      Fix PR1850 by removing an unsafe transformation from VMCore/ConstantFold.cpp. · d2265b45
      Chris Lattner authored
      Reimplement the xform in Analysis/ConstantFolding.cpp where we can use
      targetdata to validate that it is safe.  While I'm in there, fix some const
      correctness issues and generalize the interface to the "operand folder".
      
      llvm-svn: 44817
      d2265b45
    • Gordon Henriksen's avatar
      Adding a collector name attribute to Function in the IR. These · 71183b67
      Gordon Henriksen authored
      methods are new to Function:
      
        bool hasCollector() const;
        const std::string &getCollector() const;
        void setCollector(const std::string &);
        void clearCollector();
      
      The assembly representation is as such:
      
        define void @f() gc "shadow-stack" { ...
      
      The implementation uses an on-the-side table to map Functions to 
      collector names, such that there is no overhead. A StringPool is 
      further used to unique collector names, which are extremely
      likely to be unique per process.
      
      llvm-svn: 44769
      71183b67
  9. Dec 03, 2007
  10. Nov 27, 2007
  11. Nov 09, 2007
  12. Nov 04, 2007
  13. Nov 02, 2007
  14. Nov 01, 2007
    • Duncan Sands's avatar
      Executive summary: getTypeSize -> getTypeStoreSize / getABITypeSize. · 44b8721d
      Duncan Sands authored
      The meaning of getTypeSize was not clear - clarifying it is important
      now that we have x86 long double and arbitrary precision integers.
      The issue with long double is that it requires 80 bits, and this is
      not a multiple of its alignment.  This gives a primitive type for
      which getTypeSize differed from getABITypeSize.  For arbitrary precision
      integers it is even worse: there is the minimum number of bits needed to
      hold the type (eg: 36 for an i36), the maximum number of bits that will
      be overwriten when storing the type (40 bits for i36) and the ABI size
      (i.e. the storage size rounded up to a multiple of the alignment; 64 bits
      for i36).
      
      This patch removes getTypeSize (not really - it is still there but
      deprecated to allow for a gradual transition).  Instead there is:
      
      (1) getTypeSizeInBits - a number of bits that suffices to hold all
      values of the type.  For a primitive type, this is the minimum number
      of bits.  For an i36 this is 36 bits.  For x86 long double it is 80.
      This corresponds to gcc's TYPE_PRECISION.
      
      (2) getTypeStoreSizeInBits - the maximum number of bits that is
      written when storing the type (or read when reading it).  For an
      i36 this is 40 bits, for an x86 long double it is 80 bits.  This
      is the size alias analysis is interested in (getTypeStoreSize
      returns the number of bytes).  There doesn't seem to be anything
      corresponding to this in gcc.
      
      (3) getABITypeSizeInBits - this is getTypeStoreSizeInBits rounded
      up to a multiple of the alignment.  For an i36 this is 64, for an
      x86 long double this is 96 or 128 depending on the OS.  This is the
      spacing between consecutive elements when you form an array out of
      this type (getABITypeSize returns the number of bytes).  This is
      TYPE_SIZE in gcc.
      
      Since successive elements in a SequentialType (arrays, pointers
      and vectors) need to be aligned, the spacing between them will be
      given by getABITypeSize.  This means that the size of an array
      is the length times the getABITypeSize.  It also means that GEP
      computations need to use getABITypeSize when computing offsets.
      Furthermore, if an alloca allocates several elements at once then
      these too need to be aligned, so the size of the alloca has to be
      the number of elements multiplied by getABITypeSize.  Logically
      speaking this doesn't have to be the case when allocating just
      one element, but it is simpler to also use getABITypeSize in this
      case.  So alloca's and mallocs should use getABITypeSize.  Finally,
      since gcc's only notion of size is that given by getABITypeSize, if
      you want to output assembler etc the same as gcc then getABITypeSize
      is the size you want.
      
      Since a store will overwrite no more than getTypeStoreSize bytes,
      and a read will read no more than that many bytes, this is the
      notion of size appropriate for alias analysis calculations.
      
      In this patch I have corrected all type size uses except some of
      those in ScalarReplAggregates, lib/Codegen, lib/Target (the hard
      cases).  I will get around to auditing these too at some point,
      but I could do with some help.
      
      Finally, I made one change which I think wise but others might
      consider pointless and suboptimal: in an unpacked struct the
      amount of space allocated for a field is now given by the ABI
      size rather than getTypeStoreSize.  I did this because every
      other place that reserves memory for a type (eg: alloca) now
      uses getABITypeSize, and I didn't want to make an exception
      for unpacked structs, i.e. I did it to make things more uniform.
      This only effects structs containing long doubles and arbitrary
      precision integers.  If someone wants to pack these types more
      tightly they can always use a packed struct.
      
      llvm-svn: 43620
      44b8721d
  15. Oct 29, 2007
  16. Oct 22, 2007
  17. Oct 18, 2007
  18. Oct 17, 2007
  19. Sep 17, 2007
  20. Sep 04, 2007
  21. Sep 03, 2007
  22. Aug 27, 2007
    • David Greene's avatar
      · 703623d5
      David Greene authored
      Update InvokeInst to work like CallInst
      
      llvm-svn: 41506
      703623d5
  23. Aug 26, 2007
  24. Aug 21, 2007
  25. Aug 17, 2007
  26. Aug 15, 2007
  27. Aug 13, 2007
  28. Aug 10, 2007
Loading