Newer
Older
Ted Kremenek
committed
//=== StackAddrEscapeChecker.cpp ----------------------------------*- C++ -*--//
Zhongxing Xu
committed
//
// The LLVM Compiler Infrastructure
//
// This file is distributed under the University of Illinois Open Source
// License. See LICENSE.TXT for details.
//
//===----------------------------------------------------------------------===//
//
// This file defines stack address leak checker, which checks if an invalid
// stack address is stored into a global or heap location. See CERT DCL30-C.
//
//===----------------------------------------------------------------------===//
Argyrios Kyrtzidis
committed
#include "ClangSACheckers.h"
#include "clang/StaticAnalyzer/Core/Checker.h"
#include "clang/StaticAnalyzer/Core/CheckerManager.h"
#include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h"
Ted Kremenek
committed
#include "clang/StaticAnalyzer/Core/BugReporter/BugType.h"
Ted Kremenek
committed
#include "clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h"
#include "clang/Basic/SourceManager.h"
#include "llvm/ADT/SmallString.h"
Zhongxing Xu
committed
using namespace clang;
Zhongxing Xu
committed
namespace {
class StackAddrEscapeChecker : public Checker< check::PreStmt<ReturnStmt>,
check::EndPath > {
mutable OwningPtr<BuiltinBug> BT_stackleak;
mutable OwningPtr<BuiltinBug> BT_returnstack;
Zhongxing Xu
committed
public:
void checkPreStmt(const ReturnStmt *RS, CheckerContext &C) const;
void checkEndPath(CheckerContext &Ctx) const;
void EmitStackError(CheckerContext &C, const MemRegion *R,
const Expr *RetE) const;
Chris Lattner
committed
static SourceRange GenName(raw_ostream &os, const MemRegion *R,
SourceManager &SM);
Zhongxing Xu
committed
};
}
Chris Lattner
committed
SourceRange StackAddrEscapeChecker::GenName(raw_ostream &os,
Ted Kremenek
committed
const MemRegion *R,
SourceManager &SM) {
// Get the base region, stripping away fields and elements.
R = R->getBaseRegion();
Ted Kremenek
committed
SourceRange range;
os << "Address of ";
// Check if the region is a compound literal.
if (const CompoundLiteralRegion* CR = dyn_cast<CompoundLiteralRegion>(R)) {
Ted Kremenek
committed
const CompoundLiteralExpr *CL = CR->getLiteralExpr();
Ted Kremenek
committed
os << "stack memory associated with a compound literal "
"declared on line "
<< SM.getExpansionLineNumber(CL->getLocStart())
Ted Kremenek
committed
<< " returned to caller";
range = CL->getSourceRange();
}
else if (const AllocaRegion* AR = dyn_cast<AllocaRegion>(R)) {
Ted Kremenek
committed
const Expr *ARE = AR->getExpr();
SourceLocation L = ARE->getLocStart();
range = ARE->getSourceRange();
Ted Kremenek
committed
os << "stack memory allocated by call to alloca() on line "
<< SM.getExpansionLineNumber(L);
}
else if (const BlockDataRegion *BR = dyn_cast<BlockDataRegion>(R)) {
const BlockDecl *BD = BR->getCodeRegion()->getDecl();
SourceLocation L = BD->getLocStart();
range = BD->getSourceRange();
Ted Kremenek
committed
os << "stack-allocated block declared on line "
<< SM.getExpansionLineNumber(L);
}
else if (const VarRegion *VR = dyn_cast<VarRegion>(R)) {
Ted Kremenek
committed
os << "stack memory associated with local variable '"
<< VR->getString() << '\'';
range = VR->getDecl()->getSourceRange();
}
else if (const CXXTempObjectRegion *TOR = dyn_cast<CXXTempObjectRegion>(R)) {
os << "stack memory associated with temporary object of type '"
<< TOR->getValueType().getAsString() << '\'';
range = TOR->getExpr()->getSourceRange();
}
llvm_unreachable("Invalid region in ReturnStackAddressChecker.");
Ted Kremenek
committed
}
return range;
}
Ted Kremenek
committed
void StackAddrEscapeChecker::EmitStackError(CheckerContext &C, const MemRegion *R,
const Expr *RetE) const {
ExplodedNode *N = C.generateSink();
Ted Kremenek
committed
if (!N)
Ted Kremenek
committed
if (!BT_returnstack)
BT_returnstack.reset(
new BuiltinBug("Return of address to stack-allocated memory"));
Ted Kremenek
committed
// Generate a report for this bug.
SmallString<512> buf;
Ted Kremenek
committed
llvm::raw_svector_ostream os(buf);
SourceRange range = GenName(os, R, C.getSourceManager());
os << " returned to caller";
BugReport *report = new BugReport(*BT_returnstack, os.str(), N);
report->addRange(RetE->getSourceRange());
if (range.isValid())
report->addRange(range);
C.EmitReport(report);
Ted Kremenek
committed
void StackAddrEscapeChecker::checkPreStmt(const ReturnStmt *RS,
Ted Kremenek
committed
CheckerContext &C) const {
const Expr *RetE = RS->getRetValue();
if (!RetE)
return;
Ted Kremenek
committed
SVal V = C.getState()->getSVal(RetE, C.getLocationContext());
const MemRegion *R = V.getAsRegion();
Ted Kremenek
committed
if (!R)
return;
Ted Kremenek
committed
const StackSpaceRegion *SS =
dyn_cast_or_null<StackSpaceRegion>(R->getMemorySpace());
if (!SS)
return;
Ted Kremenek
committed
// Return stack memory in an ancestor stack frame is fine.
const StackFrameContext *SFC = SS->getStackFrame();
if (SFC != C.getLocationContext()->getCurrentStackFrame())
Ted Kremenek
committed
// Automatic reference counting automatically copies blocks.
David Blaikie
committed
if (C.getASTContext().getLangOpts().ObjCAutoRefCount &&
Ted Kremenek
committed
isa<BlockDataRegion>(R))
return;
EmitStackError(C, R, RetE);
Zhongxing Xu
committed
void StackAddrEscapeChecker::checkEndPath(CheckerContext &Ctx) const {
ProgramStateRef state = Ctx.getState();
Ted Kremenek
committed
// Iterate over all bindings to global variables and see if it contains
// a memory region in the stack space.
class CallBack : public StoreManager::BindingsHandler {
private:
CheckerContext &Ctx;
Ted Kremenek
committed
const StackFrameContext *CurSFC;
public:
Chris Lattner
committed
SmallVector<std::pair<const MemRegion*, const MemRegion*>, 10> V;
Ted Kremenek
committed
CallBack(CheckerContext &CC) :
Ctx(CC),
CurSFC(CC.getLocationContext()->getCurrentStackFrame())
Ted Kremenek
committed
bool HandleBinding(StoreManager &SMgr, Store store,
const MemRegion *region, SVal val) {
if (!isa<GlobalsSpaceRegion>(region->getMemorySpace()))
return true;
const MemRegion *vR = val.getAsRegion();
if (!vR)
return true;
// Under automated retain release, it is okay to assign a block
// directly to a global variable.
David Blaikie
committed
if (Ctx.getASTContext().getLangOpts().ObjCAutoRefCount &&
isa<BlockDataRegion>(vR))
return true;
Ted Kremenek
committed
if (const StackSpaceRegion *SSR =
dyn_cast<StackSpaceRegion>(vR->getMemorySpace())) {
// If the global variable holds a location in the current stack frame,
// record the binding to emit a warning.
Ted Kremenek
committed
if (SSR->getStackFrame() == CurSFC)
V.push_back(std::make_pair(region, vR));
Zhongxing Xu
committed
}
Ted Kremenek
committed
return true;
Zhongxing Xu
committed
}
Ted Kremenek
committed
};
CallBack cb(Ctx);
Ted Kremenek
committed
state->getStateManager().getStoreManager().iterBindings(state->getStore(),cb);
Ted Kremenek
committed
if (cb.V.empty())
Ted Kremenek
committed
return;
// Generate an error node.
ExplodedNode *N = Ctx.addTransition(state);
Ted Kremenek
committed
if (!N)
return;
Ted Kremenek
committed
Ted Kremenek
committed
if (!BT_stackleak)
BT_stackleak.reset(
Ted Kremenek
committed
new BuiltinBug("Stack address stored into global variable",
"Stack address was saved into a global variable. "
"This is dangerous because the address will become "
"invalid after returning from the function"));
Ted Kremenek
committed
Ted Kremenek
committed
for (unsigned i = 0, e = cb.V.size(); i != e; ++i) {
// Generate a report for this bug.
SmallString<512> buf;
Ted Kremenek
committed
llvm::raw_svector_ostream os(buf);
SourceRange range = GenName(os, cb.V[i].second,
Ctx.getSourceManager());
Ted Kremenek
committed
os << " is still referred to by the global variable '";
const VarRegion *VR = cast<VarRegion>(cb.V[i].first->getBaseRegion());
Benjamin Kramer
committed
os << *VR->getDecl()
Ted Kremenek
committed
<< "' upon returning to the caller. This will be a dangling reference";
BugReport *report = new BugReport(*BT_stackleak, os.str(), N);
Ted Kremenek
committed
if (range.isValid())
report->addRange(range);
Ctx.EmitReport(report);
Ted Kremenek
committed
}
Zhongxing Xu
committed
}
Ted Kremenek
committed
void ento::registerStackAddrEscapeChecker(CheckerManager &mgr) {
mgr.registerChecker<StackAddrEscapeChecker>();