Skip to content
  • Rafael Espindola's avatar
    Fix PR18743. · 09dcc6a5
    Rafael Espindola authored
    The IR
    @foo = private constant i32 42
    
    is valid, but before this patch we would produce an invalid MachO from it. It
    was invalid because it would use an L label in a section where the liker needs
    the labels in order to atomize it.
    
    One way of fixing it would be to just reject this IR in the backend, but that
    would not be very front end friendly.
    
    What this patch does is use an 'l' prefix in sections that we know the linker
    requires symbols for atomizing them. This allows frontends to just use
    private and not worry about which sections they go to or how the linker handles
    them.
    
    One small issue with this strategy is that now a symbol name depends on the
    section, which is not available before codegen. This is not a problem in
    practice. The reason is that it only happens with private linkage, which will
    be ignored by the non codegen users (llvm-nm and llvm-ar).
    
    llvm-svn: 201608
    09dcc6a5
Loading