Skip to content
  • Chandler Carruth's avatar
    Switch the SCEV expander and LoopStrengthReduce to use · 26c59fa8
    Chandler Carruth authored
    TargetTransformInfo rather than TargetLowering, removing one of the
    primary instances of the layering violation of Transforms depending
    directly on Target.
    
    This is a really big deal because LSR used to be a "special" pass that
    could only be tested fully using llc and by looking at the full output
    of it. It also couldn't run with any other loop passes because it had to
    be created by the backend. No longer is this true. LSR is now just
    a normal pass and we should probably lift the creation of LSR out of
    lib/CodeGen/Passes.cpp and into the PassManagerBuilder. =] I've not done
    this, or updated all of the tests to use opt and a triple, because
    I suspect someone more familiar with LSR would do a better job. This
    change should be essentially without functional impact for normal
    compilations, and only change behvaior of targetless compilations.
    
    The conversion required changing all of the LSR code to refer to the TTI
    interfaces, which fortunately are very similar to TargetLowering's
    interfaces. However, it also allowed us to *always* expect to have some
    implementation around. I've pushed that simplification through the pass,
    and leveraged it to simplify code somewhat. It required some test
    updates for one of two things: either we used to skip some checks
    altogether but now we get the default "no" answer for them, or we used
    to have no information about the target and now we do have some.
    
    I've also started the process of removing AddrMode, as the TTI interface
    doesn't use it any longer. In some cases this simplifies code, and in
    others it adds some complexity, but I think it's not a bad tradeoff even
    there. Subsequent patches will try to clean this up even further and use
    other (more appropriate) abstractions.
    
    Yet again, almost all of the formatting changes brought to you by
    clang-format. =]
    
    llvm-svn: 171735
    26c59fa8
Loading