Skip to content
  • Rafael Espindola's avatar
    Split getOpenFile into getOpenFile and getOpenFileSlice. · 3d2ac2e4
    Rafael Espindola authored
    The main observation is that we never need both the filesize and the map size.
    When mapping a slice of a file, it doesn't make sense to request a null
    terminator and that would be the only case where the filesize would be used.
    
    There are other cleanups that should be done in this area:
    
    * A client should not have to pass the size (even an explicit -1) to say if
      it wants a null terminator or not, so we should probably swap the argument
      order.
    * The default should be to not require a null terminator. Very few clients
      require this, but many end up asking for it just because it is the default.
    
    llvm-svn: 186984
    3d2ac2e4
Loading