Skip to content
  • Bob Wilson's avatar
    Add an argument to PHITranslateValue to specify the DominatorTree. If this · 66e58ac7
    Bob Wilson authored
    argument is non-null, pass it along to PHITranslateSubExpr so that it can
    prefer using existing values that dominate the PredBB, instead of just
    blindly picking the first equivalent value that it finds on a uselist.
    Also when the DominatorTree is specified, have PHITranslateValue filter
    out any result that does not dominate the PredBB.  This is basically just
    refactoring the check that used to be in GetAvailablePHITranslatedSubExpr
    and also in GVN.
    
    Despite my initial expectations, this change does not affect the results
    of GVN for any testcases that I could find, but it should help compile time.
    Before this change, if PHITranslateSubExpr picked a value that does not
    dominate, PHITranslateWithInsertion would then insert a new value, which GVN
    would later determine to be redundant and would replace.  By picking a good
    value to begin with, we save GVN the extra work of inserting and then
    replacing a new value.
    
    llvm-svn: 97010
    66e58ac7
Loading