Skip to content
  • Chandler Carruth's avatar
    Revert the series of commits starting with r166578 which introduced the · 7ec5085e
    Chandler Carruth authored
    getIntPtrType support for multiple address spaces via a pointer type,
    and also introduced a crasher bug in the constant folder reported in
    PR14233.
    
    These commits also contained several problems that should really be
    addressed before they are re-committed. I have avoided reverting various
    cleanups to the DataLayout APIs that are reasonable to have moving
    forward in order to reduce the amount of churn, and minimize the number
    of commits that were reverted. I've also manually updated merge
    conflicts and manually arranged for the getIntPtrType function to stay
    in DataLayout and to be defined in a plausible way after this revert.
    
    Thanks to Duncan for working through this exact strategy with me, and
    Nick Lewycky for tracking down the really annoying crasher this
    triggered. (Test case to follow in its own commit.)
    
    After discussing with Duncan extensively, and based on a note from
    Micah, I'm going to continue to back out some more of the more
    problematic patches in this series in order to ensure we go into the
    LLVM 3.2 branch with a reasonable story here. I'll send a note to
    llvmdev explaining what's going on and why.
    
    Summary of reverted revisions:
    
    r166634: Fix a compiler warning with an unused variable.
    r166607: Add some cleanup to the DataLayout changes requested by
             Chandler.
    r166596: Revert "Back out r166591, not sure why this made it through
             since I cancelled the command. Bleh, sorry about this!
    r166591: Delete a directory that wasn't supposed to be checked in yet.
    r166578: Add in support for getIntPtrType to get the pointer type based
             on the address space.
    llvm-svn: 167221
    7ec5085e
Loading