Skip to content
  • Chris Lattner's avatar
    This reworks some of the Diagnostic interfaces a bit to change how diagnostics · 8488c829
    Chris Lattner authored
    are formed.  In particular, a diagnostic with all its strings and ranges is now
    packaged up and sent to DiagnosticClients as a DiagnosticInfo instead of as a 
    ton of random stuff.  This has the benefit of simplifying the interface, making
    it more extensible, and allowing us to do more checking for things like access
    past the end of the various arrays passed in.
    
    In addition to introducing DiagnosticInfo, this also substantially changes how 
    Diagnostic::Report works.  Instead of being passed in all of the info required
    to issue a diagnostic, Report now takes only the required info (a location and 
    ID) and returns a fresh DiagnosticInfo *by value*.  The caller is then free to
    stuff strings and ranges into the DiagnosticInfo with the << operator.  When
    the dtor runs on the DiagnosticInfo object (which should happen at the end of
    the statement), the diagnostic is actually emitted with all of the accumulated
    information.  This is a somewhat tricky dance, but it means that the 
    accumulated DiagnosticInfo is allowed to keep pointers to other expression 
    temporaries without those pointers getting invalidated.
    
    This is just the minimal change to get this stuff working, but this will allow
    us to eliminate the zillions of variant "Diag" methods scattered throughout
    (e.g.) sema.  For example, instead of calling:
    
      Diag(BuiltinLoc, diag::err_overload_no_match, typeNames,
           SourceRange(BuiltinLoc, RParenLoc));
    
    We will soon be able to just do:
    
      Diag(BuiltinLoc, diag::err_overload_no_match)
          << typeNames << SourceRange(BuiltinLoc, RParenLoc));
    
    This scales better to support arbitrary types being passed in (not just 
    strings) in a type-safe way.  Go operator overloading?!
    
    llvm-svn: 59502
    8488c829
Loading