Skip to content
  • Duncan P. N. Exon Smith's avatar
    Reapply "LTO: add API to set strategy for -internalize" · 93be7c4f
    Duncan P. N. Exon Smith authored
    Reapply r199191, reverted in r199197 because it carelessly broke
    Other/link-opts.ll.  The problem was that calling
    createInternalizePass("main") would select
    createInternalizePass(bool("main")) instead of
    createInternalizePass(ArrayRef<const char *>("main")).  This commit
    fixes the bug.
    
    The original commit message follows.
    
    Add API to LTOCodeGenerator to specify a strategy for the -internalize
    pass.
    
    This is a new attempt at Bill's change in r185882, which he reverted in
    r188029 due to problems with the gold linker.  This puts the onus on the
    linker to decide whether (and what) to internalize.
    
    In particular, running internalize before outputting an object file may
    change a 'weak' symbol into an internal one, even though that symbol
    could be needed by an external object file --- e.g., with arclite.
    
    This patch enables three strategies:
    
    - LTO_INTERNALIZE_FULL: the default (and the old behaviour).
    - LTO_INTERNALIZE_NONE: skip -internalize.
    - LTO_INTERNALIZE_HIDDEN: only -internalize symbols with hidden
      visibility.
    
    LTO_INTERNALIZE_FULL should be used when linking an executable.
    
    Outputting an object file (e.g., via ld -r) is more complicated, and
    depends on whether hidden symbols should be internalized.  E.g., for
    ld -r, LTO_INTERNALIZE_NONE can be used when -keep_private_externs, and
    LTO_INTERNALIZE_HIDDEN can be used otherwise.  However,
    LTO_INTERNALIZE_FULL is inappropriate, since the output object file will
    eventually need to link with others.
    
    lto_codegen_set_internalize_strategy() sets the strategy for subsequent
    calls to lto_codegen_write_merged_modules() and lto_codegen_compile*().
    
    <rdar://problem/14334895>
    
    llvm-svn: 199244
    93be7c4f
Loading