Skip to content
  • Dan Gohman's avatar
    Eliminate the ISel priority queue, which used the topological order for a · f14b77eb
    Dan Gohman authored
    priority function. Instead, just iterate over the AllNodes list, which is
    already in topological order. This eliminates a fair amount of bookkeeping,
    and speeds up the isel phase by about 15% on many testcases.
    
    The impact on most targets is that AddToISelQueue calls can be simply removed.
    
    In the x86 target, there are two additional notable changes.
    
    The rule-bending AND+SHIFT optimization in MatchAddress that creates new
    pre-isel nodes during isel is now a little more verbose, but more robust.
    Instead of either creating an invalid DAG or creating an invalid topological
    sort, as it has historically done, it can now just insert the new nodes into
    the node list at a position where they will be consistent with the topological
    ordering.
    
    Also, the address-matching code has logic that checked to see if a node was
    "already selected". However, when a node is selected, it has all its uses
    taken away via ReplaceAllUsesWith or equivalent, so it won't recieve any
    further visits from MatchAddress. This code is now removed.
    
    llvm-svn: 58748
    f14b77eb
Loading