"llvm/git@repo.hca.bsc.es:lalbano/llvm-bpevl.git" did not exist on "93a9d2de8f4f73b5785d539db4dfa3fb5bbffedc"
Revert "Add r159136 back now that pr13124 has been fixed."
This reverts commit r189886. I found a corner case where this optimization is not valid: Say we have a "linkonce_odr unnamed_addr" in two translation units: * In TU 1 this optimization kicks in and makes it hidden. * In TU 2 it gets const merged with a constant that is *not* unnamed_addr, resulting in a non unnamed_addr constant with default visibility. * The static linker rules for combining visibility them produce a hidden symbol, which is incorrect from the point of view of the non unnamed_addr constant. The one place we can do this is when we know that the symbol is not used from another TU in the same shared object, i.e., during LTO. I will move it there. llvm-svn: 189954
Loading
Please register or sign in to comment