Stop diagnosing the use of inner classes as friends. ddunbar asked whether

this was useful, and on review Doug and I decided it was probably on the level
of a bug in the standard and therefore not worth a warning even in -pedantic.
If someone disagrees and urgently wants clang++ to warn about this in strict
c++98 mode, we can talk about it.

llvm-svn: 91868