Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
llvm-epi-0.8
Manage
Activity
Members
Code
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Deploy
Releases
Model registry
Analyze
Contributor analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
This is an archived project. Repository and other project resources are read-only.
Show more breadcrumbs
Roger Ferrer
llvm-epi-0.8
Commits
53a9d2da
Commit
53a9d2da
authored
11 years ago
by
John Thompson
Browse files
Options
Downloads
Patches
Plain Diff
modularize - Update main comment.
llvm-svn: 189968
parent
9406516a
No related branches found
Branches containing commit
No related tags found
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
clang-tools-extra/modularize/Modularize.cpp
+7
-11
7 additions, 11 deletions
clang-tools-extra/modularize/Modularize.cpp
with
7 additions
and
11 deletions
clang-tools-extra/modularize/Modularize.cpp
+
7
−
11
View file @
53a9d2da
...
@@ -79,20 +79,16 @@
...
@@ -79,20 +79,16 @@
//
//
// Some ideas:
// Some ideas:
//
//
// 1.
Add options to disable any of the checks, in case
// 1.
Check for and warn about "#include" directives inside 'extern "C/C++" {}'
//
there is some problem with them, or the messages get too verbose
.
//
and "namespace (name) {}" blocks
.
//
//
// 2. Try to figure out the preprocessor conditional directives that
// 2. Omit duplicate "not always provided" messages
// contribute to problems and tie them to the inconsistent definitions.
//
//
// 3.
Check for correct and consistent usage of extern "C" {} and other
// 3.
Add options to disable any of the checks, in case
//
directives. Warn about #include inside extern "C" {}
.
//
there is some problem with them, or the messages get too verbose
.
//
//
// 4. There seem to be a lot of spurious "not always provided" messages,
// 4. Try to figure out the preprocessor conditional directives that
// and many duplicates of these, which seem to occur when something is
// contribute to problems and tie them to the inconsistent definitions.
// defined within a preprocessor conditional block, even if the conditional
// always evaluates the same in the stand-alone case. Perhaps we could
// collapse the duplicates, and add an option for disabling the test (see #4).
//
//
// 5. There are some legitimate uses of preprocessor macros that
// 5. There are some legitimate uses of preprocessor macros that
// modularize will flag as errors, such as repeatedly #include'ing
// modularize will flag as errors, such as repeatedly #include'ing
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment