Fix use-of-invalid-memory found by Valgrind and Windows buildbots.

We were inserting a value into a std::vector<> while iterating over
it, which could cause the underlying memory to get deallocated
and reallocated.  While not the best solution, use an llvm::ImmutableList
for now as it is safely supports insertions during iteration.

llvm-svn: 99058