split a complex predicate out to a helper function. Simplify two for loops,

which don't need to check for falling off the end of a block *and* end of phi
nodes, since terminators are never phis.

llvm-svn: 129655