Skip to content
  1. Jul 10, 2009
  2. Jul 09, 2009
  3. Jul 08, 2009
    • Bill Wendling's avatar
      Recommit r74952 with a bug fix: · 0c9f367d
      Bill Wendling authored
      DWARF requires frame moves be specified at specific times. If you have a
      prologue like this:
      
      __Z3fooi:
      Leh_func_begin1:
      LBB1_0: ## entry
             pushl   %ebp
      Llabel1:
             movl    %esp, %ebp
      Llabel2:
             pushl   %esi
      Llabel3:
             subl    $20, %esp
             call    "L1$pb"
      "L1$pb":
             popl    %esi
      
      The "pushl %ebp" needs a table entry specifying the offset. The "movl %esp,
      %ebp" makes %ebp the new stack frame register, so that needs to be specified in
      DWARF. And "pushl %esi" saves the callee-saved %esi register, which also needs
      to be specified in DWARF.
      
      Before, all of this logic was in one method. This didn't work too well, because
      as you can see there are multiple FDE line entries that need to be created.
      
      This fix creates the "MachineMove" objects directly when they're needed; instead
      of waiting until the end, and losing information.
      
      There is some ugliness where we generate code like this:
      
      
      LBB22_0:	## entry
      	pushl	%ebp
      Llabel280:
      	movl	%esp, %ebp
      Llabel281:
      Llabel284:
      	pushl	%ebp  <----------
      	pushl	%ebx
      	pushl	%edi
      	pushl	%esi
      Llabel282:
      	subl	$328, %esp
      
      Notice the extra "pushl %ebp". If we generate a "machine move" instruction in
      the FDE for that pushl, the linker may get very confused about what value %ebp
      should have when exitting the function. I.e., it'll give it the value %esp
      instead of the %ebp value from the first "pushl". Not to mention that, in this
      case, %ebp isn't modified in the function (that's a separate bug). I put a small
      hack in to get it to work. It might be the only solution, but should be
      revisited once the above case is fixed.
      
      llvm-svn: 75047
      0c9f367d
Loading