Skip to content
  1. Jul 26, 2013
  2. Jul 25, 2013
    • Roman Divacky's avatar
      PPC32 va_list is an actual structure so va_copy needs to copy the whole · c3825df8
      Roman Divacky authored
      structure not just a pointer. This implements that and thus fixes va_copy
      on PPC32. Fixes #15286. Both bug and patch by Florian Zeitz!
      
      llvm-svn: 187158
      c3825df8
    • Manman Ren's avatar
      Debug Info: update comments and add a FIXME. · 13b63e89
      Manman Ren authored
      llvm-svn: 187157
      13b63e89
    • Rafael Espindola's avatar
      Remove dead code from the makefile build system. · bff44ddd
      Rafael Espindola authored
      Back in r140220 we removed the autoconf code that would set LLVMCC_OPTION
      since it was only used by the test-suite. This patch now removes code
      that would only be used if LLVMCC_OPTION was set.
      
      llvm-svn: 187154
      bff44ddd
    • Manman Ren's avatar
      Debug Info: improve the verifier to check field types. · 58737702
      Manman Ren authored
      Make sure the context field of DIType is MDNode.
      Fix testing cases to make them pass the verifier.
      
      llvm-svn: 187150
      58737702
    • Rafael Espindola's avatar
      72986667
    • Andrew Trick's avatar
      RegAllocGreedy comment. · f4b1ee34
      Andrew Trick authored
      llvm-svn: 187141
      f4b1ee34
    • Andrew Trick's avatar
      Evict local live ranges if they can be reassigned. · 8bb0a251
      Andrew Trick authored
      The previous change to local live range allocation also suppressed
      eviction of local ranges. In rare cases, this could result in more
      expensive register choices. This commit actually revives a feature
      that I added long ago: check if live ranges can be reassigned before
      eviction. But now it only happens in rare cases of evicting a local
      live range because another local live range wants a cheaper register.
      
      The benefit is improved code size for some benchmarks on x86 and armv7.
      
      I measured no significant compile time increase and performance
      changes are noise.
      
      llvm-svn: 187140
      8bb0a251
    • Andrew Trick's avatar
      Allocate local registers in order for optimal coloring. · 8485257d
      Andrew Trick authored
      Also avoid locals evicting locals just because they want a cheaper register.
      
      Problem: MI Sched knows exactly how many registers we have and assumes
      they can be colored. In cases where we have large blocks, usually from
      unrolled loops, greedy coloring fails. This is a source of
      "regressions" from the MI Scheduler on x86. I noticed this issue on
      x86 where we have long chains of two-address defs in the same live
      range. It's easy to see this in matrix multiplication benchmarks like
      IRSmk and even the unit test misched-matmul.ll.
      
      A fundamental difference between the LLVM register allocator and
      conventional graph coloring is that in our model a live range can't
      discover its neighbors, it can only verify its neighbors. That's why
      we initially went for greedy coloring and added eviction to deal with
      the hard cases. However, for singly defined and two-address live
      ranges, we can optimally color without visiting neighbors simply by
      processing the live ranges in instruction order.
      
      Other beneficial side effects:
      
      It is much easier to understand and debug regalloc for large blocks
      when the live ranges are allocated in order. Yes, global allocation is
      still very confusing, but it's nice to be able to comprehend what
      happened locally.
      
      Heuristics could be added to bias register assignment based on
      instruction locality (think late register pairing, banks...).
      
      Intuituvely this will make some test cases that are on the threshold
      of register pressure more stable.
      
      llvm-svn: 187139
      8485257d
Loading