Skip to content
  1. Jul 21, 2010
  2. Jul 13, 2010
    • John McCall's avatar
      Teach IR generation how to lazily emit cleanups. This has a lot of advantages, · 2b7fc382
      John McCall authored
      mostly in avoiding unnecessary work at compile time but also in producing more
      sensible block orderings.
      
      Move the destructor cleanups for local variables over to use lazy cleanups.
      Eventually all cleanups will do this;  for now we have some awkward code
      duplication.
      
      Tell IR generation just to never produce landing pads in -fno-exceptions.
      This is a much more comprehensive solution to a problem which previously was
      half-solved by checks in most cleanup-generation spots.
      
      llvm-svn: 108270
      2b7fc382
  3. Jul 07, 2010
  4. Jul 06, 2010
    • John McCall's avatar
      Validated by nightly-test runs on x86 and x86-64 darwin, including after · bd30929e
      John McCall authored
      self-host.  Hopefully these results hold up on different platforms.  
      
      I tried to keep the GNU ObjC runtime happy, but it's hard for me to test.
      Reimplement how clang generates IR for exceptions.  Instead of creating new
      invoke destinations which sequentially chain to the previous destination,
      push a more semantic representation of *why* we need the cleanup/catch/filter
      behavior, then collect that information into a single landing pad upon request.
      
      Also reorganizes how normal cleanups (i.e. cleanups triggered by non-exceptional
      control flow) are generated, since it's actually fairly closely tied in with
      the former.  Remove the need to track which cleanup scope a block is associated
      with.
      
      Document a lot of previously poorly-understood (by me, at least) behavior.
      
      The new framework implements the Horrible Hack (tm), which requires every
      landing pad to have a catch-all so that inlining will work.  Clang no longer
      requires the Horrible Hack just to make exceptions flow correctly within
      a function, however.  The HH is an unfortunate requirement of LLVM's EH IR.
      
      llvm-svn: 107631
      bd30929e
  5. Jul 01, 2010
  6. Jun 26, 2010
  7. Jun 09, 2010
  8. Jun 03, 2010
  9. May 27, 2010
  10. May 22, 2010
  11. May 21, 2010
  12. May 06, 2010
  13. May 05, 2010
    • Douglas Gregor's avatar
      Reimplement code generation for copying fields in the · 94f9a482
      Douglas Gregor authored
      implicitly-generated copy constructor. Previously, Sema would perform
      some checking and instantiation to determine which copy constructors,
      etc., would be called, then CodeGen would attempt to figure out which
      copy constructor to call... but would get it wrong, or poke at an
      uninstantiated default argument, or fail in other ways.
      
      The new scheme is similar to what we now do for the implicit
      copy-assignment operator, where Sema performs all of the semantic
      analysis and builds specific ASTs that look similar to the ASTs we'd
      get from explicitly writing the copy constructor, so that CodeGen need
      only do a direct translation.
      
      However, it's not quite that simple because one cannot explicit write
      elementwise copy-construction of an array. So, I've extended
      CXXBaseOrMemberInitializer to contain a list of indexing variables
      used to copy-construct the elements. For example, if we have:
      
        struct A { A(const A&); };
        
        struct B {
          A array[2][3];
        };
      
      then we generate an implicit copy assignment operator for B that looks
      something like this:
      
        B::B(const B &other) : array[i0][i1](other.array[i0][i1]) { }
      
      CodeGen will loop over the invented variables i0 and i1 to visit all
      elements in the array, so that each element in the destination array
      will be copy-constructed from the corresponding element in the source
      array. Of course, if we're dealing with arrays of scalars or class
      types with trivial copy-assignment operators, we just generate a
      memcpy rather than a loop.
      
      Fixes PR6928, PR5989, and PR6887. Boost.Regex now compiles and passes
      all of its regression tests.
      
      Conspicuously missing from this patch is handling for the exceptional
      case, where we need to destruct those objects that we have
      constructed. I'll address that case separately.
      
      llvm-svn: 103079
      94f9a482
  14. May 04, 2010
  15. May 03, 2010
  16. May 02, 2010
  17. May 01, 2010
    • Douglas Gregor's avatar
      Complete reimplementation of the synthesis for implicitly-defined copy · b139cd58
      Douglas Gregor authored
      assignment operators. 
      
      Previously, Sema provided type-checking and template instantiation for
      copy assignment operators, then CodeGen would synthesize the actual
      body of the copy constructor. Unfortunately, the two were not in sync,
      and CodeGen might pick a copy-assignment operator that is different
      from what Sema chose, leading to strange failures, e.g., link-time
      failures when CodeGen called a copy-assignment operator that was not
      instantiation, run-time failures when copy-assignment operators were
      overloaded for const/non-const references and the wrong one was
      picked, and run-time failures when by-value copy-assignment operators
      did not have their arguments properly copy-initialized.
      
      This implementation synthesizes the implicitly-defined copy assignment
      operator bodies in Sema, so that the resulting ASTs encode exactly
      what CodeGen needs to do; there is no longer any special code in
      CodeGen to synthesize copy-assignment operators. The synthesis of the
      body is relatively simple, and we generate one of three different
      kinds of copy statements for each base or member:
      
        - For a class subobject, call the appropriate copy-assignment
          operator, after overload resolution has determined what that is.
        - For an array of scalar types or an array of class types that have
          trivial copy assignment operators, construct a call to
          __builtin_memcpy.
        - For an array of class types with non-trivial copy assignment
          operators, synthesize a (possibly nested!) for loop whose inner
          statement calls the copy constructor.
        - For a scalar type, use built-in assignment.
      
      This patch fixes at least a few tests cases in Boost.Spirit that were
      failing because CodeGen picked the wrong copy-assignment operator
      (leading to link-time failures), and I suspect a number of undiagnosed
      problems will also go away with this change.
      
      Some of the diagnostics we had previously have gotten worse with this
      change, since we're going through generic code for our
      type-checking. I will improve this in a subsequent patch.
      
      llvm-svn: 102853
      b139cd58
    • Anders Carlsson's avatar
      Simplify EmitCopyCtorCall. · b136e626
      Anders Carlsson authored
      llvm-svn: 102849
      b136e626
    • Anders Carlsson's avatar
      Simplify EmitClassAggrMemberwiseCopy. · aab3b573
      Anders Carlsson authored
      llvm-svn: 102848
      aab3b573
    • Anders Carlsson's avatar
      Clean up EmitClassMemberwiseCopy further. · ab826ad1
      Anders Carlsson authored
      llvm-svn: 102846
      ab826ad1
    • Anders Carlsson's avatar
      Get rid of a parameter from EmitClassMemberwiseCopy. · 820022c5
      Anders Carlsson authored
      llvm-svn: 102845
      820022c5
    • Anders Carlsson's avatar
  18. Apr 30, 2010
Loading