Skip to content
  1. Nov 01, 2007
    • Duncan Sands's avatar
      Executive summary: getTypeSize -> getTypeStoreSize / getABITypeSize. · 44b8721d
      Duncan Sands authored
      The meaning of getTypeSize was not clear - clarifying it is important
      now that we have x86 long double and arbitrary precision integers.
      The issue with long double is that it requires 80 bits, and this is
      not a multiple of its alignment.  This gives a primitive type for
      which getTypeSize differed from getABITypeSize.  For arbitrary precision
      integers it is even worse: there is the minimum number of bits needed to
      hold the type (eg: 36 for an i36), the maximum number of bits that will
      be overwriten when storing the type (40 bits for i36) and the ABI size
      (i.e. the storage size rounded up to a multiple of the alignment; 64 bits
      for i36).
      
      This patch removes getTypeSize (not really - it is still there but
      deprecated to allow for a gradual transition).  Instead there is:
      
      (1) getTypeSizeInBits - a number of bits that suffices to hold all
      values of the type.  For a primitive type, this is the minimum number
      of bits.  For an i36 this is 36 bits.  For x86 long double it is 80.
      This corresponds to gcc's TYPE_PRECISION.
      
      (2) getTypeStoreSizeInBits - the maximum number of bits that is
      written when storing the type (or read when reading it).  For an
      i36 this is 40 bits, for an x86 long double it is 80 bits.  This
      is the size alias analysis is interested in (getTypeStoreSize
      returns the number of bytes).  There doesn't seem to be anything
      corresponding to this in gcc.
      
      (3) getABITypeSizeInBits - this is getTypeStoreSizeInBits rounded
      up to a multiple of the alignment.  For an i36 this is 64, for an
      x86 long double this is 96 or 128 depending on the OS.  This is the
      spacing between consecutive elements when you form an array out of
      this type (getABITypeSize returns the number of bytes).  This is
      TYPE_SIZE in gcc.
      
      Since successive elements in a SequentialType (arrays, pointers
      and vectors) need to be aligned, the spacing between them will be
      given by getABITypeSize.  This means that the size of an array
      is the length times the getABITypeSize.  It also means that GEP
      computations need to use getABITypeSize when computing offsets.
      Furthermore, if an alloca allocates several elements at once then
      these too need to be aligned, so the size of the alloca has to be
      the number of elements multiplied by getABITypeSize.  Logically
      speaking this doesn't have to be the case when allocating just
      one element, but it is simpler to also use getABITypeSize in this
      case.  So alloca's and mallocs should use getABITypeSize.  Finally,
      since gcc's only notion of size is that given by getABITypeSize, if
      you want to output assembler etc the same as gcc then getABITypeSize
      is the size you want.
      
      Since a store will overwrite no more than getTypeStoreSize bytes,
      and a read will read no more than that many bytes, this is the
      notion of size appropriate for alias analysis calculations.
      
      In this patch I have corrected all type size uses except some of
      those in ScalarReplAggregates, lib/Codegen, lib/Target (the hard
      cases).  I will get around to auditing these too at some point,
      but I could do with some help.
      
      Finally, I made one change which I think wise but others might
      consider pointless and suboptimal: in an unpacked struct the
      amount of space allocated for a field is now given by the ABI
      size rather than getTypeStoreSize.  I did this because every
      other place that reserves memory for a type (eg: alloca) now
      uses getABITypeSize, and I didn't want to make an exception
      for unpacked structs, i.e. I did it to make things more uniform.
      This only effects structs containing long doubles and arbitrary
      precision integers.  If someone wants to pack these types more
      tightly they can always use a packed struct.
      
      llvm-svn: 43620
      44b8721d
    • Owen Anderson's avatar
      Fix test/Transforms/DeadStoreElimination/PartialStore.ll, which had been · 2ed651ac
      Owen Anderson authored
      silently failing because of an incorrect run line for some time.
      
      llvm-svn: 43605
      2ed651ac
    • Chris Lattner's avatar
      Fix InstCombine/2007-10-31-RangeCrash.ll · 74709473
      Chris Lattner authored
      llvm-svn: 43596
      74709473
  2. Oct 31, 2007
  3. Oct 30, 2007
  4. Oct 29, 2007
  5. Oct 27, 2007
    • Evan Cheng's avatar
      A number of LSR fixes: · 9dbe99dc
      Evan Cheng authored
      - ChangeCompareStride only reuse stride that is larger than current stride. It
        will let the general reuse mechanism to try to reuse a smaller stride.
      - Watch out for multiplication overflow in ChangeCompareStride.
      - Replace std::set with SmallPtrSet.
      
      llvm-svn: 43408
      9dbe99dc
  6. Oct 26, 2007
  7. Oct 25, 2007
  8. Oct 24, 2007
  9. Oct 22, 2007
    • Dan Gohman's avatar
      Strength reduction improvements. · e0c3d9f3
      Dan Gohman authored
       - Avoid attempting stride-reuse in the case that there are users that
         aren't addresses. In that case, there will be places where the
         multiplications won't be folded away, so it's better to try to
         strength-reduce them.
      
       - Several SSE intrinsics have operands that strength-reduction can
         treat as addresses. The previous item makes this more visible, as
         any non-address use of an IV can inhibit stride-reuse.
      
       - Make ValidStride aware of whether there's likely to be a base
         register in the address computation. This prevents it from thinking
         that things like stride 9 are valid on x86 when the base register is
         already occupied.
      
      Also, XFAIL the 2007-08-10-LEA16Use32.ll test; the new logic to avoid
      stride-reuse elimintes the LEA in the loop, so the test is no longer
      testing what it was intended to test.
      
      llvm-svn: 43231
      e0c3d9f3
    • Dan Gohman's avatar
      Move the SCEV object factors from being static members of the individual · a37eaf2b
      Dan Gohman authored
      SCEV subclasses to being non-static member functions of the ScalarEvolution
      class.
      
      llvm-svn: 43224
      a37eaf2b
    • Anton Korobeynikov's avatar
      Reg2Mem cleanup and optimizations: · 7499a3b0
      Anton Korobeynikov authored
       - enable phi instructions demotion to stack
       - create alloca instructions in the entry block
      
      llvm-svn: 43208
      7499a3b0
  10. Oct 18, 2007
  11. Oct 17, 2007
  12. Oct 15, 2007
  13. Oct 12, 2007
Loading