Skip to content
  1. May 13, 2010
    • Douglas Gregor's avatar
      Disable the available_externally optimization for inline virtual · 500d9f82
      Douglas Gregor authored
      methods for which the key function is guaranteed to be in another
      translation unit. Unfortunately, this guarantee isn't the case when
      dealing with shared libraries that fail to export these virtual method
      definitions. 
      
      I'm reopening PR6747 so we can consider this again at a later point in
      time.
      
      llvm-svn: 103741
      500d9f82
    • Douglas Gregor's avatar
      Rework when and how vtables are emitted, by tracking where vtables are · 88d292cc
      Douglas Gregor authored
      "used" (e.g., we will refer to the vtable in the generated code) and
      when they are defined (i.e., because we've seen the key function
      definition). Previously, we were effectively tracking "potential
      definitions" rather than uses, so we were a bit too eager about emitting
      vtables for classes without key functions. 
      
      The new scheme:
        - For every use of a vtable, Sema calls MarkVTableUsed() to indicate
        the use. For example, this occurs when calling a virtual member
        function of the class, defining a constructor of that class type,
        dynamic_cast'ing from that type to a derived class, casting
        to/through a virtual base class, etc.
        - For every definition of a vtable, Sema calls MarkVTableUsed() to
        indicate the definition. This happens at the end of the translation
        unit for classes whose key function has been defined (so we can
        delay computation of the key function; see PR6564), and will also
        occur with explicit template instantiation definitions.
       - For every vtable defined/used, we mark all of the virtual member
       functions of that vtable as defined/used, unless we know that the key
       function is in another translation unit. This instantiates virtual
       member functions when needed.
        - At the end of the translation unit, Sema tells CodeGen (via the
        ASTConsumer) which vtables must be defined (CodeGen will define
        them) and which may be used (for which CodeGen will define the
        vtables lazily). 
      
      From a language perspective, both the old and the new schemes are
      permissible: we're allowed to instantiate virtual member functions
      whenever we want per the standard. However, all other C++ compilers
      were more lazy than we were, and our eagerness was both a performance
      issue (we instantiated too much) and a portability problem (we broke
      Boost test cases, which now pass).
      
      Notes:
        (1) There's a ton of churn in the tests, because the order in which
        vtables get emitted to IR has changed. I've tried to isolate some of
        the larger tests from these issues.
        (2) Some diagnostics related to
        implicitly-instantiated/implicitly-defined virtual member functions
        have moved to the point of first use/definition. It's better this
        way.
        (3) I could use a review of the places where we MarkVTableUsed, to
        see if I missed any place where the language effectively requires a
        vtable.
      
      Fixes PR7114 and PR6564.
      
      llvm-svn: 103718
      88d292cc
    • Devang Patel's avatar
      If given location is invalid then use current location. · c5ffabc9
      Devang Patel authored
      This fixes recent regressions reported by gdb testsuite. 
      Tighter verification of debug info generated by FE found these regressions.
      
      Refactor code to extract line number and column number from SourceLocation.
      
      llvm-svn: 103678
      c5ffabc9
  2. May 12, 2010
  3. May 11, 2010
  4. May 10, 2010
  5. May 09, 2010
  6. May 08, 2010
  7. May 07, 2010
  8. May 06, 2010
  9. May 05, 2010
    • Fariborz Jahanian's avatar
      This patch deals with Sema Part of Setter/Getter synthesis · 25491a22
      Fariborz Jahanian authored
      of properties which are of C++ objects. Code Gen to follow
      (Radar 7468090).
      
      llvm-svn: 103123
      25491a22
    • Douglas Gregor's avatar
      When we emit a non-constant initializer for a global variable of · d450f06e
      Douglas Gregor authored
      reference type, make sure that the initializer we build is the
      of the appropriate type for the *reference*, not for the thing that it
      refers to. Fixes PR7050.
      
      llvm-svn: 103115
      d450f06e
    • Douglas Gregor's avatar
      For thread-safe static initialization of local statics with · 370eadf3
      Douglas Gregor authored
      destructors, place the __cxa_atexit call after the __cxa_guard_release
      call, mimicking GCC/LLVM-GCC behavior. Noticed while debugging
      something related.
      
      llvm-svn: 103088
      370eadf3
    • Alexis Hunt's avatar
      Reapplying patch to change StmtNodes.def to StmtNodes.td, this time · 656bb314
      Alexis Hunt authored
      with no whitespace. This will allow statements to be referred to in
      attribute TableGen files.
      
      llvm-svn: 103087
      656bb314
    • Alexis Hunt's avatar
      Revert r103072; I accidentally ended up deleting a bunch of trailing · a8136cc4
      Alexis Hunt authored
      whitespace which makes this patch unreadable. Will recommit without the
      whitespace.
      
      llvm-svn: 103086
      a8136cc4
    • Douglas Gregor's avatar
      Reimplement code generation for copying fields in the · 94f9a482
      Douglas Gregor authored
      implicitly-generated copy constructor. Previously, Sema would perform
      some checking and instantiation to determine which copy constructors,
      etc., would be called, then CodeGen would attempt to figure out which
      copy constructor to call... but would get it wrong, or poke at an
      uninstantiated default argument, or fail in other ways.
      
      The new scheme is similar to what we now do for the implicit
      copy-assignment operator, where Sema performs all of the semantic
      analysis and builds specific ASTs that look similar to the ASTs we'd
      get from explicitly writing the copy constructor, so that CodeGen need
      only do a direct translation.
      
      However, it's not quite that simple because one cannot explicit write
      elementwise copy-construction of an array. So, I've extended
      CXXBaseOrMemberInitializer to contain a list of indexing variables
      used to copy-construct the elements. For example, if we have:
      
        struct A { A(const A&); };
        
        struct B {
          A array[2][3];
        };
      
      then we generate an implicit copy assignment operator for B that looks
      something like this:
      
        B::B(const B &other) : array[i0][i1](other.array[i0][i1]) { }
      
      CodeGen will loop over the invented variables i0 and i1 to visit all
      elements in the array, so that each element in the destination array
      will be copy-constructed from the corresponding element in the source
      array. Of course, if we're dealing with arrays of scalars or class
      types with trivial copy-assignment operators, we just generate a
      memcpy rather than a loop.
      
      Fixes PR6928, PR5989, and PR6887. Boost.Regex now compiles and passes
      all of its regression tests.
      
      Conspicuously missing from this patch is handling for the exceptional
      case, where we need to destruct those objects that we have
      constructed. I'll address that case separately.
      
      llvm-svn: 103079
      94f9a482
    • Anders Carlsson's avatar
      Use a more appropriate LLVM type for the vtable pointer. · 58fe1756
      Anders Carlsson authored
      llvm-svn: 103078
      58fe1756
    • Douglas Gregor's avatar
      Unbreak CMake build. · ecc60b99
      Douglas Gregor authored
      llvm-svn: 103077
      ecc60b99
    • Alexis Hunt's avatar
      b9f408a8
  10. May 04, 2010
Loading